[eslint] Add extensions folder to linting

Includes linting of the extensions folder.
Also add .mjs files to the PRESUBMIT which was previously missing.

Bug: none
Change-Id: I6ae5bb8a218461c3b2bf07d95310d79c57f2cdd9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6177277
Reviewed-by: Philip Pfaffe <[email protected]>
Reviewed-by: Benedikt Meurer <[email protected]>
Commit-Queue: Nikolay Vitkov <[email protected]>

Author: Lightning00Blade

PRESUBMIT.py

@@ -301,7 +301,7 @@ def _CheckDevToolsLint(input_api, output_api):
 
     should_bail_out, files_to_lint = _getFilesToLint(
         input_api, output_api, lint_config_files, default_linted_directories,
-        ['.css', '.js', '.ts'], results)
+        ['.css', '.mjs', '.js', '.ts'], results)
     if should_bail_out:
         return results
 

config/typescript/tsconfig.eslint.json

@@ -14,6 +14,7 @@
     "../../front_end/**/*.ts",
     "../../inspector_overlay/**/*.ts",
     "../../scripts/protocol_typescript/*.ts",
-    "../../test/**/*.ts"
+    "../../test/**/*.ts",
+    "../../extensions/**/*.ts",
   ]
 }

extensions/cxx_debugging/e2e/TestDriver.ts

@@ -3,7 +3,7 @@
 // found in the LICENSE file.
 
 import {assert} from 'chai';
-import {type ElementHandle, type JSHandle} from 'puppeteer-core';
+import type {ElementHandle, JSHandle} from 'puppeteer-core';
 import {TestConfig} from 'test/conductor/test_config.js';
 import {
   CONSOLE_TAB_SELECTOR,
@@ -26,7 +26,6 @@ import {
   assertNotNullOrUndefined,
   click,
   clickElement,
-  debuggerStatement,
   getBrowserAndPages,
   getPendingEvents,
   installEventListener,
@@ -35,7 +34,6 @@ import {
   waitForFunction,
 } from 'test/shared/helper.js';
 
-
 import {
   type Action,
   loadTests,

extensions/cxx_debugging/e2e/cxx-debugging-extension-helpers.ts

@@ -40,6 +40,7 @@ export interface Step {
 export interface TestSpec {
   name: string;
   test: string;
+  // eslint-disable-next-line @typescript-eslint/naming-convention
   extension_parameters?: string;
   script?: Step[];
   file?: string;

extensions/cxx_debugging/e2e/standalone/MemoryInspector_test.ts

@@ -18,7 +18,6 @@ import {
   waitForMany,
 } from 'test/shared/helper.js';
 
-
 import {
   openTestSuiteResourceInSourcesPanel,
 } from '../cxx-debugging-extension-helpers.js';

extensions/cxx_debugging/src/CreditsItem.ts

@@ -2,14 +2,13 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-/* eslint-disable rulesdir/check-component-naming, rulesdir/no-underscored-properties, rulesdir/no-style-tags-in-lit-html, rulesdir/no-a-tags-in-lit-html, rulesdir/lit-html-host-this */
 import {html, render} from 'lit-html';
 
-export type CreditsItemData = {
-  title: string,
-  homepage: string,
-  license: string,
-};
+export interface CreditsItemData {
+  title: string;
+  homepage: string;
+  license: string;
+}
 
 function onClick(e: KeyboardEvent): void {
   const {target} = e;

extensions/cxx_debugging/src/CustomFormatters.ts

@@ -2,10 +2,10 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-import {type Chrome} from '../../../extension-api/ExtensionAPI.js';
+import type {Chrome} from '../../../extension-api/ExtensionAPI.js';
 
-import {type WasmValue} from './WasmTypes.js';
-import {type HostInterface} from './WorkerRPC.js';
+import type {WasmValue} from './WasmTypes.js';
+import type {HostInterface} from './WorkerRPC.js';
 
 export interface FieldInfo {
   typeId: string;
@@ -363,7 +363,7 @@ export class CXXValue implements Value, LazyObject {
         const formattedValue = await formatter.format(this.wasm, value);
         return lazyObjectFromAny(formattedValue, this.objectStore, this.type, this.displayValue, this.memoryAddress)
             .asRemoteObject();
-      } catch (e) {
+      } catch {
         // Fallthrough
       }
     }

extensions/cxx_debugging/src/DWARFSymbols.ts

@@ -4,7 +4,7 @@
 
 import './Formatters.js';
 
-import {type Chrome} from '../../../extension-api/ExtensionAPI.js';
+import type {Chrome} from '../../../extension-api/ExtensionAPI.js';
 
 import * as Formatters from './CustomFormatters.js';
 import {
@@ -15,7 +15,7 @@ import {
 } from './ModuleConfiguration.js';
 import type * as SymbolsBackend from './SymbolsBackend.js';
 import createSymbolsBackend from './SymbolsBackend.js';
-import {type HostInterface} from './WorkerRPC.js';
+import type {HostInterface} from './WorkerRPC.js';
 
 function mapVector<T, ApiT>(vector: SymbolsBackend.Vector<ApiT>, callback: (apiElement: ApiT) => T): T[] {
   const elements: T[] = [];
@@ -26,11 +26,11 @@ function mapVector<T, ApiT>(vector: SymbolsBackend.Vector<ApiT>, callback: (apiE
   return elements;
 }
 
-type ScopeInfo = {
-  type: 'GLOBAL'|'LOCAL'|'PARAMETER',
-  typeName: string,
-  icon?: string,
-};
+interface ScopeInfo {
+  type: 'GLOBAL'|'LOCAL'|'PARAMETER';
+  typeName: string;
+  icon?: string;
+}
 
 type LazyFSNode = FS.FSNode&{contents: {cacheLength: Function, length: number}};
 
@@ -196,7 +196,7 @@ export class DWARFLanguageExtensionPlugin implements Chrome.DevTools.LanguageExt
           // Sometimes these stick around.
           try {
             backend.FS.unlink(absolutePath);
-          } catch (_) {
+          } catch {
           }
           // Ensure directory exists
           if (parentDirectory.length > 1) {
@@ -211,9 +211,9 @@ export class DWARFLanguageExtensionPlugin implements Chrome.DevTools.LanguageExt
           const wrapper = (): void => {
             try {
               cacheLength.apply(node.contents);
-              this.hostInterface.reportResourceLoad(dwoURL, {success: true, size: node.contents.length});
+              void this.hostInterface.reportResourceLoad(dwoURL, {success: true, size: node.contents.length});
             } catch (e) {
-              this.hostInterface.reportResourceLoad(dwoURL, {success: false, errorMessage: (e as Error).message});
+              void this.hostInterface.reportResourceLoad(dwoURL, {success: false, errorMessage: (e as Error).message});
               // Rethrow any error fetching the content as errno 44 (EEXIST)
               // TypeScript doesn't know about the ErrnoError constructor
               // @ts-ignore

extensions/cxx_debugging/src/DevToolsPluginHost.ts

@@ -2,11 +2,11 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-import {DEFAULT_MODULE_CONFIGURATIONS, type ModuleConfigurations} from './ModuleConfiguration.js';
-import {type Chrome} from '../../../extension-api/ExtensionAPI.js';
+import type {Chrome} from '../../../extension-api/ExtensionAPI.js';
 
-import {WorkerRPC, type AsyncHostInterface, type WorkerInterface} from './WorkerRPC.js';
-import {type WasmValue} from './WasmTypes.js';
+import {DEFAULT_MODULE_CONFIGURATIONS, type ModuleConfigurations} from './ModuleConfiguration.js';
+import type {WasmValue} from './WasmTypes.js';
+import {type AsyncHostInterface, type WorkerInterface, WorkerRPC} from './WorkerRPC.js';
 
 export class WorkerPlugin implements Chrome.DevTools.LanguageExtensionPlugin, AsyncHostInterface {
   private readonly worker: Worker;
@@ -127,8 +127,8 @@ if (typeof chrome !== 'undefined' && typeof chrome.storage !== 'undefined') {
   }
 
   const defaultConfig = {
-    'moduleConfigurations': DEFAULT_MODULE_CONFIGURATIONS,
-    'logPluginApiCalls': false,
+    moduleConfigurations: DEFAULT_MODULE_CONFIGURATIONS,
+    logPluginApiCalls: false,
   };
   chrome.storage.local.get(defaultConfig, ({moduleConfigurations, logPluginApiCalls}) => {
     let pluginPromise = registerPlugin(moduleConfigurations, logPluginApiCalls);

extensions/cxx_debugging/src/DevToolsPluginWorker.ts

@@ -2,15 +2,12 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-import {type Chrome} from '../../../extension-api/ExtensionAPI.js';
+import type {Chrome} from '../../../extension-api/ExtensionAPI.js';
 
 import {createPlugin, type ResourceLoader} from './DWARFSymbols.js';
-import {type ModuleConfigurations} from './ModuleConfiguration.js';
-
+import type {ModuleConfigurations} from './ModuleConfiguration.js';
 import {deserializeWasmMemory, deserializeWasmValue, kMaxWasmValueSize, type WasmValue} from './WasmTypes.js';
-
-import {SynchronousIOMessage} from './WorkerRPC.js';
-import {WorkerRPC, type Channel, type HostInterface, type WorkerInterface} from './WorkerRPC.js';
+import {type Channel, type HostInterface, SynchronousIOMessage, type WorkerInterface, WorkerRPC} from './WorkerRPC.js';
 
 class SynchronousLinearMemoryMessage extends SynchronousIOMessage<ArrayBuffer> {
   deserialize(length: number): ArrayBuffer {

extensions/cxx_debugging/src/DevToolsPluginWorkerMain.ts

@@ -5,4 +5,5 @@
 import {RPCInterface} from './DevToolsPluginWorker.js';
 import {ResourceLoader} from './MEMFSResourceLoader.js';
 
+// eslint-disable-next-line @typescript-eslint/no-explicit-any
 new RPCInterface(globalThis as any, new ResourceLoader());

extensions/cxx_debugging/src/ExtensionOptions.ts

@@ -2,20 +2,16 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-/* eslint-disable rulesdir/check-component-naming */
-/* eslint-disable rulesdir/inject-checkbox-styles */
-/* eslint-disable rulesdir/lit-html-host-this */
-
 import './CreditsItem.js';
 import './ModuleConfigurationList.js';
 
 import {html, render} from 'lit-html';
-import {until} from 'lit-html/directives/until.js';  // eslint-disable-line rulesdir/es-modules-import
+import {until} from 'lit-html/directives/until.js';
 
-import {type CreditsItemData} from './CreditsItem.js';
-import {type Storage} from './DevToolsPluginHost.js';
+import type {CreditsItemData} from './CreditsItem.js';
+import type {Storage} from './DevToolsPluginHost.js';
 import {DEFAULT_MODULE_CONFIGURATIONS} from './ModuleConfiguration.js';
-import {type ModuleConfigurationsChangedEvent} from './ModuleConfigurationList.js';
+import type {ModuleConfigurationsChangedEvent} from './ModuleConfigurationList.js';
 
 const CREDITS_ITEMS: CreditsItemData[] = [
   {
@@ -667,7 +663,7 @@ export class ExtensionOptions extends HTMLElement {
   private render(): void {
     const configurations = new Promise<{[key: string]: unknown}>(
         resolve => chrome.storage.local.get(
-            {'moduleConfigurations': DEFAULT_MODULE_CONFIGURATIONS, 'logPluginApiCalls': false}, resolve));
+            {moduleConfigurations: DEFAULT_MODULE_CONFIGURATIONS, logPluginApiCalls: false}, resolve));
     const moduleConfigurationListPromise = configurations.then(
         data => html`
             <devtools-cxx-debugging-module-configuration-list .data=${data} @module-configurations-changed=${
@@ -682,7 +678,7 @@ export class ExtensionOptions extends HTMLElement {
               <input data-input="true" type="checkbox" .checked=${data.logPluginApiCalls} @change=${
             (event: Event): void => {
               const checkbox = event.target as HTMLInputElement;
-              this.updateConfigurations({'logPluginApiCalls': checkbox.checked});
+              this.updateConfigurations({logPluginApiCalls: checkbox.checked});
             }}>
               <span>Log calls to plugin API</span>
             </label>`);

extensions/cxx_debugging/src/Formatters.ts

@@ -10,7 +10,7 @@ import {
   type Value,
   type WasmInterface,
 } from './CustomFormatters.js';
-import {type ForeignObject, type WasmValue} from './WasmTypes.js';
+import type {ForeignObject} from './WasmTypes.js';
 
 /*
  * Numbers
@@ -149,8 +149,10 @@ CustomFormatters.addFormatter({
 
 type CharArrayConstructor = typeof Uint8Array|typeof Uint16Array|typeof Uint32Array;
 function formatRawString<T extends CharArrayConstructor>(
-    wasm: WasmInterface, value: Value, charType: T, decode: (chars: InstanceType<T>) => string): string|
-    {[key: string]: Value | null} {
+    wasm: WasmInterface, value: Value, charType: T, decode: (chars: InstanceType<T>) => string): string|{
+  [key: string]: Value|null,
+}
+{
   const address = value.asUint32();
   if (address < Constants.SAFE_HEAP_START) {
     return formatPointerOrReference(wasm, value);
@@ -180,15 +182,20 @@ function formatRawString<T extends CharArrayConstructor>(
   return formatPointerOrReference(wasm, value);
 }
 
-export function formatCString(wasm: WasmInterface, value: Value): string|{[key: string]: Value | null} {
-  return formatRawString(wasm, value, Uint8Array, str => new TextDecoder().decode(str));
+export function formatCString(wasm: WasmInterface, value: Value): string|{
+  [key: string]: Value|null,
 }
+{ return formatRawString(wasm, value, Uint8Array, str => new TextDecoder().decode(str)); }
 
-export function formatU16CString(wasm: WasmInterface, value: Value): string|{[key: string]: Value | null} {
-  return formatRawString(wasm, value, Uint16Array, str => new TextDecoder('utf-16le').decode(str));
+export function formatU16CString(wasm: WasmInterface, value: Value): string|{
+  [key: string]: Value|null,
 }
+{ return formatRawString(wasm, value, Uint16Array, str => new TextDecoder('utf-16le').decode(str)); }
 
-export function formatCWString(wasm: WasmInterface, value: Value): string|{[key: string]: Value | null} {
+export function formatCWString(wasm: WasmInterface, value: Value): string|{
+  [key: string]: Value|null,
+}
+{
   // emscripten's wchar is 4 byte
   return formatRawString(wasm, value, Uint32Array, str => Array.from(str).map(v => String.fromCodePoint(v)).join(''));
 }

extensions/cxx_debugging/src/MEMFSResourceLoader.ts

@@ -5,7 +5,7 @@
 import type {Chrome} from '../../../extension-api/ExtensionAPI.js';
 
 import type * as DWARFSymbols from './DWARFSymbols.js';
-import {type HostInterface} from './WorkerRPC.js';
+import type {HostInterface} from './WorkerRPC.js';
 
 export class ResourceLoader implements DWARFSymbols.ResourceLoader {
   protected async fetchSymbolsData(rawModule: DWARFSymbols.RawModule, url: URL, hostInterface: HostInterface):
@@ -39,11 +39,11 @@ export class ResourceLoader implements DWARFSymbols.ResourceLoader {
         symbolsResponse.arrayBuffer(),
         symbolsDwpResponse && symbolsDwpResponse.ok ? symbolsDwpResponse.arrayBuffer() : undefined,
       ]);
-      hostInterface.reportResourceLoad(url.href, {success: true, size: symbolsData.byteLength});
+      void hostInterface.reportResourceLoad(url.href, {success: true, size: symbolsData.byteLength});
       if (symbolsDwpData) {
-        hostInterface.reportResourceLoad(dwpUrl, {success: true, size: symbolsDwpData.byteLength});
+        void hostInterface.reportResourceLoad(dwpUrl, {success: true, size: symbolsDwpData.byteLength});
       } else {
-        hostInterface.reportResourceLoad(
+        void hostInterface.reportResourceLoad(
             dwpUrl, {success: false, errorMessage: `Failed to fetch dwp file: ${symbolsDwpError}`});
       }
       return {symbolsData, symbolsDwpData};
@@ -52,11 +52,11 @@ export class ResourceLoader implements DWARFSymbols.ResourceLoader {
     if (rawModule.url !== url.href) {
       const errorMessage = `NotFoundError: Unable to load debug symbols from '${url}' for the WebAssembly module '${
           rawModule.url}' (${statusText}), double-check the parameter to -gseparate-dwarf in your Emscripten link step`;
-      hostInterface.reportResourceLoad(url.href, {success: false, errorMessage});
+      void hostInterface.reportResourceLoad(url.href, {success: false, errorMessage});
       throw new Error(errorMessage);
     }
     const errorMessage = `NotFoundError: Unable to load debug symbols from '${url}' (${statusText})`;
-    hostInterface.reportResourceLoad(url.href, {success: false, errorMessage});
+    void hostInterface.reportResourceLoad(url.href, {success: false, errorMessage});
     throw new Error(errorMessage);
   }
 
@@ -74,7 +74,7 @@ export class ResourceLoader implements DWARFSymbols.ResourceLoader {
     // This file is sometimes preserved on reload, causing problems.
     try {
       fileSystem.unlink('/' + symbolsFileName);
-    } catch (_) {
+    } catch {
     }
 
     fileSystem.createDataFile(

extensions/cxx_debugging/src/ModuleConfiguration.ts

@@ -11,14 +11,14 @@ import {globMatch} from './GlobMatch.js';
  * and `settings set target.source-map old new` feature that
  * is found in LLDB.
  */
-export type PathSubstitution = {
+export interface PathSubstitution {
   readonly from: string; readonly to: string;
-};
+}
 
 /**
  * List of {@type PathSubstitution}s.
  */
-export type PathSubstitutions = ReadonlyArray<PathSubstitution>;
+export type PathSubstitutions = readonly PathSubstitution[];
 
 /**
  * Resolve a source path (as stored in DWARF debugging information) to an absolute URL.
@@ -77,16 +77,16 @@ export function resolveSourcePathToURL(pathSubstitutions: PathSubstitutions, sou
  * The name can be a wildcard pattern, and {@see globMatch} will be used to
  * match the name against the URL of the WebAssembly module file.
  */
-export type ModuleConfiguration = {
+export interface ModuleConfiguration {
   readonly name?: string; readonly pathSubstitutions: PathSubstitutions;
-};
+}
 
 /**
  * List of {@type ModuleConfiguration}s. These lists are intended to have
  * a default configuration, whose name field is `undefined`, which is chosen
  * when no matching named configuration is found.
  */
-export type ModuleConfigurations = ReadonlyArray<ModuleConfiguration>;
+export type ModuleConfigurations = readonly ModuleConfiguration[];
 
 /**
  * Locate the configuration for a given `something.wasm` module file name.