Skip to content

Commit 287be69

Browse files
adamraineDevtools-frontend LUCI CQ
authored and
Devtools-frontend LUCI CQ
committed
Remove Web SQL from Lighthouse web test
This web test has become flaky downstream in Lighthouse. Web SQL is not always surfaced in the warning message. The warning message can still be tested with just IndexedDB, so we can remove Web SQL from this test. Bug: none Change-Id: Ia73ad928bcb724049ee3578722b29beb3e57108f Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2929758 Commit-Queue: Paul Irish <[email protected]> Reviewed-by: Paul Irish <[email protected]>
1 parent 1c5639a commit 287be69

File tree

2 files changed

+1
-8
lines changed

2 files changed

+1
-8
lines changed

test/webtests/http/tests/devtools/lighthouse/lighthouse-clear-data-warning-expected.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,5 +11,5 @@ Tests that Lighthouse panel displays a warning when important data may affect pe
1111
[x] Clear storage
1212
[x] Simulated throttling
1313
Generate report: enabled visible
14-
Warning Text: There may be stored data affecting loading performance in these locations: Web SQL, IndexedDB. Audit this page in an incognito window to prevent those resources from affecting your scores.
14+
Warning Text: There may be stored data affecting loading performance in this location: IndexedDB. Audit this page in an incognito window to prevent those resources from affecting your scores.
1515

test/webtests/http/tests/devtools/lighthouse/resources/lighthouse-storage.html

-7
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,6 @@
44
<script>
55
// Indexeddb
66
window.indexedDB.open("DataBase", 3);
7-
8-
// WebSQL
9-
var db = openDatabase('mydb', '1.0', 'Test', 2 * 1024 * 1024);
10-
db.transaction(function (tx) {
11-
tx.executeSql('CREATE TABLE IF NOT EXISTS LOGS (id unique, log)');
12-
tx.executeSql('INSERT INTO LOGS (id, log) VALUES (1, "foobar")');
13-
});
147
</script>
158
</head>
169
<body>

0 commit comments

Comments
 (0)