Skip to content

Commit 2a1b3b3

Browse files
Lightning00BladeDevtools-frontend LUCI CQ
authored and
Devtools-frontend LUCI CQ
committed
Update StyleLint to v16
Stylelint v16 deprecated CJS so I moved our lint script to ESM, and fixed all the deprecation warning. The only place I needed to silence them were tests, as we import CJS there. Bug: none Change-Id: Iae4d2df76c855a9738b774a2d035f22509770215 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6138610 Commit-Queue: Nikolay Vitkov <[email protected]> Reviewed-by: Benedikt Meurer <[email protected]>
1 parent 924fc2c commit 2a1b3b3

File tree

1,912 files changed

+99546
-73351
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

1,912 files changed

+99546
-73351
lines changed

.stylelintrc.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"extends": "stylelint-config-standard",
33
"plugins": [
4-
"./scripts/stylelint_rules/lib/use_theme_colors.js"
4+
"./scripts/stylelint_rules/lib/use_theme_colors.mjs"
55
],
66
"rules": {
77
"plugin/use_theme_colors": true,

PRESUBMIT.py

+3-2
Original file line numberDiff line numberDiff line change
@@ -257,7 +257,7 @@ def _CheckDevToolsRunBuildTests(input_api, output_api):
257257
def _CheckDevToolsLint(input_api, output_api):
258258
results = [output_api.PresubmitNotifyResult('Lint Check:')]
259259
lint_path = input_api.os_path.join(input_api.PresubmitLocalPath(),
260-
'scripts', 'test', 'run_lint_check.js')
260+
'scripts', 'test', 'run_lint_check.mjs')
261261

262262
front_end_directory = input_api.os_path.join(
263263
input_api.PresubmitLocalPath(), 'front_end')
@@ -292,7 +292,8 @@ def _CheckDevToolsLint(input_api, output_api):
292292
'.stylelintrc.json'),
293293
input_api.os_path.join(input_api.PresubmitLocalPath(),
294294
'.stylelintignore'),
295-
input_api.os_path.join(scripts_directory, 'test', 'run_lint_check.js'),
295+
input_api.os_path.join(scripts_directory, 'test',
296+
'run_lint_check.mjs'),
296297
]
297298

298299
lint_config_files = _getAffectedFiles(input_api, lint_related_files, [],

front_end/panels/explain/components/consoleInsight.css

+1-1
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ main {
119119
line-height: 20px;
120120

121121
p {
122-
margin-block: 1em 1em;
122+
margin-block: 1em;
123123
}
124124

125125
ul {

front_end/panels/issues/issuesTree.css

+1-1
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@
9090
}
9191

9292
p {
93-
margin-block: 2px 2px;
93+
margin-block: 2px;
9494
}
9595

9696
/* Override selected tree item styles for issues to avoid changing width. */

front_end/panels/layer_viewer/layerDetailsView.css

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ table td:first-child {
1919
ul {
2020
list-style: none;
2121
padding-inline-start: 0;
22-
margin-block: 0 0;
22+
margin-block: 0;
2323
}
2424

2525
.devtools-link.link-margin {

front_end/panels/timeline/timelinePanel.css

+1-1
Original file line numberDiff line numberDiff line change
@@ -549,7 +549,7 @@
549549
}
550550

551551
.timeline-details-view-body > div {
552-
overflow: hidden hidden;
552+
overflow: hidden;
553553
}
554554

555555
.timeline-details-chip-title > div {

0 commit comments

Comments
 (0)