Skip to content

Commit 8dcbdb8

Browse files
TimvdLippeCommit Bot
authored and
Commit Bot
committed
Remove npm run start script
It is superseded by the runtime flag `--custom-devtools-frontend`, as documented in our README. We can no longer keep this script around, as it blocks the inclusion of TypeScript-authored files in the source tree. [email protected],[email protected] Design-Doc: https://docs.google.com/document/d/1COgCBWWuTh2o-Zbp6h_z0h0LtlJaimaEDsION4RZPxc/edit Bug: 1061037, 1011811 Change-Id: Id7a347f28acf7a3a065c5c3dea4e74443d4ac7ed Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2247653 Commit-Queue: Tim van der Lippe <[email protected]> Reviewed-by: Yang Guo <[email protected]>
1 parent 38562dd commit 8dcbdb8

File tree

3 files changed

+1
-144
lines changed

3 files changed

+1
-144
lines changed

package.json

+1-2
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
"check-loc": "python scripts/test/run_localization_check.py",
2929
"check-type": "echo \"If you want to typecheck with TypeScript, run \\\"autoninja -C out/X\\\". If you want to typecheck with Closure, run \\\"npm run check-type-closure\\\"\"",
3030
"check-type-closure": "python scripts/test/run_type_check.py",
31-
"chrome": "third_party/node/node.py scripts/hosted_mode/launch_chrome.js",
3231
"components-server": "third_party/node/node.py scripts/component_server/server.js",
3332
"debug-e2etest": "DEBUG=1 python scripts/test/run_test_suite.py --test-suite=e2e",
3433
"debug-test": "third_party/node/node.py scripts/npm_test.js --debug-devtools",
@@ -46,7 +45,7 @@
4645
"screenshottest": "python scripts/test/run_test_suite.py --test-suite=screenshots",
4746
"server": "third_party/node/node.py scripts/hosted_mode/server.js",
4847
"setup-dtrun": "cd scripts/devtools_run && npm link",
49-
"start": "third_party/node/node.py scripts/hosted_mode/start_chrome_and_server.js",
48+
"start": "node -e 'console.log(`This script has been removed in favor of --custom-devtools-frontend. For more information, see https://docs.google.com/document/d/1COgCBWWuTh2o-Zbp6h_z0h0LtlJaimaEDsION4RZPxc/edit?usp=sharing`);'",
5049
"test": "third_party/node/node.py scripts/npm_test.js",
5150
"test-local": "third_party/node/node.py scripts/npm_test.js --layout-tests-directory=test/webtests/",
5251
"ts_library-test": "./third_party/typescript/tests/verify_ts_libary.sh",

scripts/hosted_mode/launch_chrome.js

-130
This file was deleted.

scripts/hosted_mode/start_chrome_and_server.js

-12
This file was deleted.

0 commit comments

Comments
 (0)