Skip to content

Commit c725faa

Browse files
ergunshDevtools-frontend LUCI CQ
authored andcommitted
[cleanup] Remove UMA instrumentation for ColorPickerOpenedFrom
Chromium CL: crrev.com/c/5954270 Bug: 374763823 Change-Id: I17d4846d86e347ac1410f071bf96361cee241445 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5953716 Reviewed-by: Benedikt Meurer <[email protected]> Commit-Queue: Benedikt Meurer <[email protected]> Auto-Submit: Ergün Erdoğmuş <[email protected]> Commit-Queue: Ergün Erdoğmuş <[email protected]>
1 parent 595ae84 commit c725faa

File tree

5 files changed

+0
-17
lines changed

5 files changed

+0
-17
lines changed

front_end/core/host/InspectorFrontendHostAPI.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -483,7 +483,6 @@ export const enum EnumeratedHistogram {
483483
CSSHintShown = 'DevTools.CSSHintShown',
484484
LighthouseModeRun = 'DevTools.LighthouseModeRun',
485485
LighthouseCategoryUsed = 'DevTools.LighthouseCategoryUsed',
486-
ColorPickerOpenedFrom = 'DevTools.ColorPickerOpenedFrom',
487486
CSSPropertyDocumentation = 'DevTools.CSSPropertyDocumentation',
488487
SwatchActivated = 'DevTools.SwatchActivated',
489488
AnimationPlaybackRateChanged = 'DevTools.AnimationPlaybackRateChanged',

front_end/core/host/UserMetrics.ts

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -312,11 +312,6 @@ export class UserMetrics {
312312
EnumeratedHistogram.LighthouseCategoryUsed, type, LighthouseCategoryUsed.MAX_VALUE);
313313
}
314314

315-
colorPickerOpenedFrom(type: ColorPickerOpenedFrom): void {
316-
InspectorFrontendHostInstance.recordEnumeratedHistogram(
317-
EnumeratedHistogram.ColorPickerOpenedFrom, type, ColorPickerOpenedFrom.MAX_VALUE);
318-
}
319-
320315
cssPropertyDocumentation(type: CSSPropertyDocumentation): void {
321316
InspectorFrontendHostInstance.recordEnumeratedHistogram(
322317
EnumeratedHistogram.CSSPropertyDocumentation, type, CSSPropertyDocumentation.MAX_VALUE);
@@ -1031,12 +1026,6 @@ export enum DevtoolsExperiments {
10311026
MAX_VALUE = 103,
10321027
}
10331028

1034-
export const enum ColorPickerOpenedFrom {
1035-
SOURCES_PANEL = 0,
1036-
STYLES_TAB = 1,
1037-
MAX_VALUE = 2,
1038-
}
1039-
10401029
export const enum CSSPropertyDocumentation {
10411030
SHOWN = 0,
10421031
TOGGLED_ON = 1,

front_end/devtools_compatibility.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -441,7 +441,6 @@ const EnumeratedHistogram = {
441441
NetworkPanelResponsePreviewOpened: 'DevTools.NetworkPanelResponsePreviewOpened',
442442
StyleTextCopied: 'DevTools.StyleTextCopied',
443443
SyncSetting: 'DevTools.SyncSetting',
444-
ColorPickerOpenedFrom: 'DevTools.ColorPickerOpenedFrom',
445444
CSSPropertyDocumentation: 'DevTools.CSSPropertyDocumentation',
446445
SwatchActivated: 'DevTools.SwatchActivated',
447446
AnimationPlaybackRateChanged: 'DevTools.AnimationPlaybackRateChanged',

front_end/panels/elements/ColorSwatchPopoverIcon.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
// found in the LICENSE file.
44

55
import * as Common from '../../core/common/common.js';
6-
import * as Host from '../../core/host/host.js';
76
import * as i18n from '../../core/i18n/i18n.js';
87
import * as Bindings from '../../models/bindings/bindings.js';
98
import * as ColorPicker from '../../ui/legacy/components/color_picker/color_picker.js';
@@ -217,7 +216,6 @@ export class ColorSwatchPopoverIcon extends Common.ObjectWrapper.ObjectWrapper<C
217216
}
218217

219218
UI.Context.Context.instance().setFlavor(ColorSwatchPopoverIcon, this);
220-
Host.userMetrics.colorPickerOpenedFrom(Host.UserMetrics.ColorPickerOpenedFrom.STYLES_TAB);
221219
}
222220

223221
private spectrumResized(): void {

front_end/panels/sources/CSSPlugin.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
// found in the LICENSE file.
44

55
import * as Common from '../../core/common/common.js';
6-
import * as Host from '../../core/host/host.js';
76
import * as i18n from '../../core/i18n/i18n.js';
87
import type * as Platform from '../../core/platform/platform.js';
98
import {assertNotNullOrUndefined} from '../../core/platform/platform.js';
@@ -258,7 +257,6 @@ function createCSSTooltip(active: ActiveTooltip): CodeMirror.Tooltip {
258257
spectrum.addEventListener(ColorPicker.Spectrum.Events.SIZE_CHANGED, () => view.requestMeasure());
259258
spectrum.setColor(active.color);
260259
widget = spectrum;
261-
Host.userMetrics.colorPickerOpenedFrom(Host.UserMetrics.ColorPickerOpenedFrom.SOURCES_PANEL);
262260
} else {
263261
const spectrum = new InlineEditor.BezierEditor.BezierEditor(active.curve);
264262
widget = spectrum;

0 commit comments

Comments
 (0)