existing NODE_OPTIONS not escaped properly

[dreadjr]

Describe the bug
When NODE_OPTIONS has an existing value e.g. NODE_OPTIONS='--require "./lib/tracing.js"' it causes an error on build/deploy during startup of the firebase function.

Additional context
How are you using GCP buildpacks?

• pack and the gcr.io/buildpacks/builder
• Cloud Functions
• Cloud Run
• Cloud Build
• App Engine Standard
• App Engine Flex
• Firebase App Hosting

Did this used to work?
(Yes)
Was this working before? When did you start noticing these errors? When heapsize.sh introduced into the bazel build.

What language is your project primarily written in?
(Node.js)

Steps To Reproduce
Steps to reproduce the behavior:

1. firebase deploy --only functions

Expected behavior
To properly concentrate the existing options with the heapsize.

Actual behavior
What actually happened?
Build/deploy startup error

If applicable, add screenshots / logs / error messages

Trying to start the instance on deploy of firebase v2 (cloud run)

�[31;1mERROR: �[0mfailed to launch: exec.d: failed to decode output from exec.d file at path '/layers/google.nodejs.runtime/heapsize/exec.d/heapsize.sh': toml: line 1: expected a top-level item to end with a newline, comment, or EOF, but got '.' instead

"env": [
  {
  "name": "NODE_OPTIONS",
  "value": "--require "./lib/tracing.js""
  },
  ...
]

[sharmaharisam]

Hi @dreadjr ,

Can you confirm if this issue happens during the build/during container startup for you?
Can you also share detailed build logs for the failure case? I am unable to reproduce this. I tried to doing a source deploy with the following env var: --set-build-env-vars NODE_OPTIONS='--require "./lib/tracing.js"'

The build succeeded for me.

[dreadjr]

Hi @dreadjr ,

Can you confirm if this issue happens during the build/during container startup for you? Can you also share detailed build logs for the failure case? I am unable to reproduce this. I tried to doing a source deploy with the following env var: --set-build-env-vars NODE_OPTIONS='--require "./lib/tracing.js"'

The build succeeded for me.

I added more details to the description, and I can provide you directly with more detailed logs (since they contain some sensitive values).

Also when I run the script directly you can see the output and how the double quotes are handled and what NODE_OPTIONS get set as.

& NODE_OPTIONS='--require "./lib/tracing.js"' ./heapsize.sh

NODE_OPTIONS="--require "./lib/tracing.js" --max-old-space-size=819"

[sharmaharisam]

Thanks @dreadjr
I was able to reproduce the issue and have raised a fix for this. Please expect the fix to be rolled out in ~2 weeks time.