Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automation to check for un-labelled resources #2240

Open
NimJay opened this issue Mar 28, 2024 · 1 comment
Open

Add automation to check for un-labelled resources #2240

NimJay opened this issue Mar 28, 2024 · 1 comment
Assignees
Labels

Comments

@NimJay
Copy link
Contributor

NimJay commented Mar 28, 2024

  • Problem: As we were working on a Jump Start Solution, we realized that we forgot to label the resources using the "labels" variable.
  • See this Google-internal doc. This document states that all Blueprint resources should set the "labels" argument (where applicable) to "var.labels".
  • Ideally, we would either:
    • have automation that adds these labels in any Terraform resource that supports the "label" argument.
    • have automation that warns developers that Terraform resource that
  • Feature request: Would it be possible to add a check inside the lint GitHub Action that warns users about unlabelled resources (for resources that support the "labels" arg)?

Additional info

@bharathkkb
Copy link
Member

bharathkkb commented Apr 4, 2024

Thanks for the suggestion @NimJay! This is definitely something on our radar - a potential implementation path is via tflint #1453 which runs as part of our lint workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants