Skip to content
This repository has been archived by the owner on Feb 16, 2025. It is now read-only.

Add notification of nightly test failures #414

Open
grayside opened this issue May 27, 2022 · 6 comments
Open

Add notification of nightly test failures #414

grayside opened this issue May 27, 2022 · 6 comments
Labels
component: delivery Related to automation, testing, deployment of the application. persona: maintainer [meta] Related to project maintenance. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@grayside
Copy link
Contributor

Proposal

Add notification of nightly test failures. Email is okay, but preference would be to open issues, and not open a new issue if an existing test failure issue is open.

Problems this will solve

Ensuring test failures are in the team's work queue and dashboards without daily manual review.

@grayside grayside added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p0 Highest priority. Critical issue. P0 implies highest priority. component: delivery Related to automation, testing, deployment of the application. persona: maintainer [meta] Related to project maintenance. labels May 27, 2022
@grayside grayside assigned grayside and ace-n and unassigned grayside Jun 27, 2022
@ace-n
Copy link
Contributor

ace-n commented Jun 27, 2022

TODO: @ace-n to collaborate with @glasnt and see what the best approach is.

(Context: currently, our CI processes run in Cloud Build.)

@ace-n
Copy link
Contributor

ace-n commented Jun 29, 2022

This is 🚨 blocked 🚨 on this PR

That PR has since been merged, so this is unblocked.

Ideally, I'd implement this collaboratively with someone else. (It's a great opportunity excuse to learn how Emblem's CI systems work!)

UPDATE: @rogerthatdev has expressed interest in working on this; I'll set up a sync w/ them internally.

@ace-n
Copy link
Contributor

ace-n commented Jul 21, 2022

There are currently three nightly tests running in our Emblem setup, per our testing documentation:

  1. Content API
  2. Installation Test
  3. Website

@rogerthatdev and I will create separate PRs to enable build failure notifications for each.

Relevant links: docs / base PR

@rogerthatdev rogerthatdev self-assigned this Jul 21, 2022
@ace-n
Copy link
Contributor

ace-n commented Jul 21, 2022

@rogerthatdev and I met today

Takeaway
We should document the "plugin model" used by the Installation tests.

These notifiers can live in the /cloud-build-notifiers category


Next steps

  • [Issue Comment (optional)] Identify the TF resources that we need based on this tutorial
  • [PR 1, Setup] Put those resources in a PR in their own "plugin"
  • [PR 2a, Setup] Add required Dockerfile contents
  • [PR 2b, Setup] Add CD build for Cloud Build notifier image
  • [PR 3, Execution] Get everything working end-to-end (i.e. perform any bugfixes)

Notes from our August 1st meeting:

  • We'll need to create a new google_storage_bucket
  • Put files in a /cloud-build-notifiers "plugin" directory within the repo root
  • For now, only support notifications for nightly tests
  • Dedupe resources where we can (i.e. have one build notification setup for multiple builds, if practical)

@ace-n ace-n removed their assignment Aug 1, 2022
@ace-n
Copy link
Contributor

ace-n commented Aug 1, 2022

Assigning @rogerthatdev since we've synced on this.

(Roger - as always, feel free to ask me any questions you might have! 🙂 )

@ace-n
Copy link
Contributor

ace-n commented Aug 15, 2022

Downgrading to P2, since this is not required for our next major milestone.^ (It is a fast follow, however.)

^ AKA Public Preview

@ace-n ace-n added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed priority: p0 Highest priority. Critical issue. P0 implies highest priority. labels Aug 15, 2022
@pattishin pattishin added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. labels Oct 14, 2022
@rogerthatdev rogerthatdev removed their assignment Jul 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: delivery Related to automation, testing, deployment of the application. persona: maintainer [meta] Related to project maintenance. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

4 participants