Skip to content

logging_writer grant to Trigger SA may be duplicated #57

Description

@rolandostar

google_service_account.trigger_sa.email might have redundant grants in the terraform modules

In infra/modules/firebase-hosting-service/main.tf#L53-L58:

# 5. Give the trigger SA permission to write logs
resource "google_project_iam_member" "logging_writer" {
  project = var.gcp_project_id
  role    = "roles/logging.logWriter"
  member  = "serviceAccount:${google_service_account.trigger_sa.email}"
}

And in infra/modules/cloud-run-service/main.tf:

resource "google_project_iam_member" "logging_writer_binding" {
  project = var.gcp_project_id
  role    = "roles/logging.logWriter"
  member  = "serviceAccount:${google_service_account.trigger_sa.email}"
}

Since google_project_iam_member is non-authoritative this should be safe but Terraform will still track both entries in the state, flagging to verify whether it's intended or not.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions