Skip to content

Commit 4ed76fc

Browse files
Merge pull request #3155 from GoogleCloudPlatform/acpana-patch-9
docs: use new fuzzer example
2 parents f1cb53d + c793e12 commit 4ed76fc

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

Diff for: docs/develop-resources/deep-dives/4-add-controller.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -50,4 +50,4 @@ KCC_USE_DIRECT_RECONCILERS=<YOUR KIND> hack/compare-mock fixtures/<your_resource
5050
### Exit Criteria
5151

5252
* The PRs shall pass the MockGCP tests
53-
* For Beta resource, the roundtrip fuzz tests shall cover all the fields in `spec `and `status.observedState `fields [example](https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/0bbac86ace6ab2f4051b574f026d5fe47fa05b75/pkg/controller/direct/redis/cluster/roundtrip_test.go#L92)
53+
* For Beta resource, the roundtrip fuzz tests shall cover all the fields in `spec `and `status.observedState `fields. [Example](https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/f313b00c52f09c4a52a2eb5fe2c15fa4b30a05fd/pkg/controller/direct/discoveryengine/fuzzers.go#L26-L47)

Diff for: docs/develop-resources/scenarios/migrate-tf-resource-beta.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ Follow [deep-dives Step 4](../deep-dives/4-add-controller.md).
6161

6262
### PR Reviews
6363

64-
* We require the roundtrip fuzz tests to cover all the fields in `spec` and `status.observedState` fields [example](https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/0bbac86ace6ab2f4051b574f026d5fe47fa05b75/pkg/controller/direct/redis/cluster/roundtrip_test.go#L92) (For mapper)
64+
* We require the roundtrip fuzz tests to cover all the fields in `spec` and `status.observedState` fields [Example](https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/f313b00c52f09c4a52a2eb5fe2c15fa4b30a05fd/pkg/controller/direct/discoveryengine/fuzzers.go#L26-L47)
6565
* We require the MockGCP pass without any change to the `create.yaml`, `update.yaml` and `_generated_object_<resource>.golden.yaml` files.
6666

6767
## Switch to the direct controller (optional)

0 commit comments

Comments
 (0)