chore: improve error handling when building release bundle

Author: justinsb

dev/tasks/build-release-bundle

@@ -34,6 +34,12 @@ mkdir -p "${BIN_DIR}"
 
 LICENSING_SCRIPT=${REPO_ROOT}/scripts/add-license-header-to-yaml.sh
 
+function add_license() {
+  file=$1
+  $LICENSING_SCRIPT ${file} > ${file}.tmp
+  mv ${file}.tmp ${file}
+}
+
 GOBIN=${BIN_DIR}/ go install sigs.k8s.io/kustomize/kustomize/[email protected]
 export PATH=${BIN_DIR}/:$PATH
 
@@ -102,17 +108,22 @@ sed -i "s/0.0.0-dev/${VERSION}/g" ${AUTOPILOT_WORKLOAD_IDENTITY_BUNDLE_DIR}/*
 # Build the namespaced-mode install bundle (uses workload identity)
 NAMESPACED_BUNDLE_DIR=${BUNDLE_DIR}/install-bundle-namespaced
 mkdir -p ${NAMESPACED_BUNDLE_DIR}
-$LICENSING_SCRIPT <(kustomize build config/installbundle/releases/scopes/namespaced/shared-components) > ${NAMESPACED_BUNDLE_DIR}/0-cnrm-system.yaml
-$LICENSING_SCRIPT <(kustomize build config/installbundle/releases/scopes/namespaced/per-namespace-components) |\
+kustomize build config/installbundle/releases/scopes/namespaced/shared-components > ${NAMESPACED_BUNDLE_DIR}/0-cnrm-system.yaml
+add_license ${NAMESPACED_BUNDLE_DIR}/0-cnrm-system.yaml
+kustomize build config/installbundle/releases/scopes/namespaced/per-namespace-components |\
   sed -e 's/mynamespace/${NAMESPACE?}/g' > ${NAMESPACED_BUNDLE_DIR}/per-namespace-components.yaml
+add_license ${NAMESPACED_BUNDLE_DIR}/per-namespace-components.yaml
 cp $CRDS_FILE ${NAMESPACED_BUNDLE_DIR}/crds.yaml
 sed -i "s/0.0.0-dev/${VERSION}/g" ${NAMESPACED_BUNDLE_DIR}/*
+
 # Create the autopilot variant of the namespaced-mode install bundle
 AUTOPILOT_NAMESPACED_BUNDLE_DIR=${BUNDLE_DIR}/install-bundle-autopilot-namespaced
 mkdir -p ${AUTOPILOT_NAMESPACED_BUNDLE_DIR}
-$LICENSING_SCRIPT <(kustomize build config/installbundle/releases/scopes/namespaced/autopilot-shared-components) > ${AUTOPILOT_NAMESPACED_BUNDLE_DIR}/0-cnrm-system.yaml
-$LICENSING_SCRIPT <(kustomize build config/installbundle/releases/scopes/namespaced/per-namespace-components) |\
+kustomize build config/installbundle/releases/scopes/namespaced/autopilot-shared-components > ${AUTOPILOT_NAMESPACED_BUNDLE_DIR}/0-cnrm-system.yaml
+add_license ${AUTOPILOT_NAMESPACED_BUNDLE_DIR}/0-cnrm-system.yaml
+kustomize build config/installbundle/releases/scopes/namespaced/per-namespace-components |\
   sed -e 's/mynamespace/${NAMESPACE?}/g' > ${AUTOPILOT_NAMESPACED_BUNDLE_DIR}/per-namespace-components.yaml
+add_license ${AUTOPILOT_NAMESPACED_BUNDLE_DIR}/per-namespace-components.yaml
 cp $CRDS_FILE ${AUTOPILOT_NAMESPACED_BUNDLE_DIR}/crds.yaml
 sed -i "s/0.0.0-dev/${VERSION}/g" ${AUTOPILOT_NAMESPACED_BUNDLE_DIR}/*
 

scripts/add-license-header-to-yaml.sh

@@ -21,7 +21,7 @@ set -o pipefail
 REPO_ROOT="$(git rev-parse --show-toplevel)"
 
 FILE=${1:-}
-[[ -z "${FILE:-}" ]] && { echo "Error: file not specified"; exit 1; }
+[[ -z "${FILE:-}" ]] && { echo "Error: file not specified" >&2; exit 1; }
 
 LICENSE_HEADER=${REPO_ROOT}/scripts/license-header.yaml