Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up the duplicated (and problematic) "generate-go-crd-clients" #3037

Open
3 tasks done
yuwenma opened this issue Oct 30, 2024 · 0 comments · May be fixed by #3038
Open
3 tasks done

Clean up the duplicated (and problematic) "generate-go-crd-clients" #3037

yuwenma opened this issue Oct 30, 2024 · 0 comments · May be fixed by #3038
Labels
enhancement New feature or request

Comments

@yuwenma
Copy link
Collaborator

yuwenma commented Oct 30, 2024

Checklist

  • I did not find a related open enhancement request.
  • I understand that enhancement requests filed in the GitHub repository are by default low priority.
  • If this request is time-sensitive, I have submitted a corresponding issue with GCP support.

Describe the feature or resource

This issue is for tracking purpose

This originated from triaging a bug that block promoting a KMS Alpha resource to Beta (direct), where the KMS services have both TF and direct resources in both Alpha and Beta versions, and the autogenerated client cannot import the autogenerated API (alpha), when promoting alpha to beta and keep the alpha CRD. It turns out that the bug comes from generate-go-crd-clients where it cannot support auto-generating APIs with multiple CRD versions. Instead, it deletes the autogenerated alpha API.

The real problem is that the generate-go-crd-clients generates the api and go client lib using go template, rather than relying on the sig-k8s its own solution (controller-gen).

As we migrating to the new "direct" approach, we are using the controller-gen to build the api client and can now support multiple CRD versions. However, the generate-go-crd-clients is still there in the presubmit infra, generating duplicate code and blocks the new direct resources.

We want to remove it from the presubmit infra immediately to unblock new resources. But we cannot delete the existing auto-generate code because OSS users may still need it.

Additional information

No response

Importance

No response

@yuwenma yuwenma added the enhancement New feature or request label Oct 30, 2024
@yuwenma yuwenma linked a pull request Oct 30, 2024 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant