Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SecretMangerSecret spec.rotation.rotationPeriod incorrectly handled by the immutable webhook. #3051

Open
3 tasks done
yuwenma opened this issue Oct 31, 2024 · 0 comments
Open
3 tasks done
Labels
bug Something isn't working

Comments

@yuwenma
Copy link
Collaborator

yuwenma commented Oct 31, 2024

Checklist

Bug Description

This issue is for tracking purpose. There might be some prior art that determine to set the field as immutable.

The spec.rotation.rotationPeriod is a mutable field. The GCP server allows updating its value. However, the Terraform-based approach raises the following errors if the field is changed.

{"severity":"info","timestamp":"2024-10-31T04:37:17.605Z","msg":"resource is not ready","kind":"SecretManagerSecret","name":"secretmanagersecret-qvghyx4vjl63hwa","conditions":[{"lastTransitionTime":"2024-10-31T04:36:45Z","message":"Update call failed: cannot make changes to immutable field(s): [Field Name: rotation.0.rotationPeriod, Got: 7200s, Wanted: 3600s]; please refer to our troubleshooting doc: https://cloud.google.com/config-connector/docs/troubleshooting","reason":"UpdateFailed","status":"False","type":"Ready"}]}

Additional Diagnostic Information

n/a

Kubernetes Cluster Version

n/a

Config Connector Version

n/a

Config Connector Mode

namespaced mode (default)

Log Output

No response

Steps to reproduce the issue

hack/record-gcp fixtures/secretmanagersecretfull

YAML snippets

No response

@yuwenma yuwenma added the bug Something isn't working label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant