Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mockgcp: BigQueryDataTransferConfig: datasetid constraints #3615

Open
acpana opened this issue Feb 5, 2025 · 2 comments
Open

mockgcp: BigQueryDataTransferConfig: datasetid constraints #3615

acpana opened this issue Feb 5, 2025 · 2 comments

Comments

@acpana
Copy link
Collaborator

acpana commented Feb 5, 2025

The expected datasetid format in real has some constraints:

Dataset IDs must be alphanumeric (plus underscores and dashes) and must be at most 1024 characters long

We can probably also shift this error left! In the controller.
@acpana acpana changed the title mockgcp: BigQueryDataTransferConfig: mockgcp: BigQueryDataTransferConfig: datasetid constraints Feb 5, 2025
@acpana
Copy link
Collaborator Author

acpana commented Feb 5, 2025

cc @jingyih

@jingyih
Copy link
Collaborator

jingyih commented Feb 5, 2025 •
edited
Loading

Shifting left is a great idea! Maybe we could try the new "Declarative Validation" feature. Practically though, if the datasetID is from the metadata.name of the BigQueryDataset object, Kubernetes may already enforce stricter constraints on metadata.name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@acpana @jingyih