Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated output-only types should use output-only subtypes #3616

Open
3 tasks done
maqiuyujoyce opened this issue Feb 5, 2025 · 0 comments
Open
3 tasks done

Generated output-only types should use output-only subtypes #3616

maqiuyujoyce opened this issue Feb 5, 2025 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@maqiuyujoyce
Copy link
Collaborator

Checklist

  • I did not find a related open enhancement request.
  • I understand that enhancement requests filed in the GitHub repository are by default low priority.
  • If this request is time-sensitive, I have submitted a corresponding issue with GCP support.

Describe the feature or resource

When I tried to generate the types for AlloyDBCluster using the following command:

go run main.go generate-types \
     --service google.cloud.alloydb.v1beta \
     --api-version "alloydb.cnrm.cloud.google.com/v1beta1" \
     --resource AlloyDBCluster:Cluster \
     --resource AlloyDBInstance:Instance

I found that the generated output-only type ClusterObservedState contains non-output-only subtypes like EncryptionInfo, though it also contains output-only subtypes like GeminiClusterConfigObservedState.

I'd expect the output-only types should use output-only subtypes instead of using non-output-only subtypes.

Additional information

No response

Importance

No response

@maqiuyujoyce maqiuyujoyce added the enhancement New feature or request label Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants