Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty types should not be generated in type generation #3618

Open
3 tasks done
maqiuyujoyce opened this issue Feb 5, 2025 · 0 comments
Open
3 tasks done

Empty types should not be generated in type generation #3618

maqiuyujoyce opened this issue Feb 5, 2025 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@maqiuyujoyce
Copy link
Collaborator

Checklist

  • I did not find a related open enhancement request.
  • I understand that enhancement requests filed in the GitHub repository are by default low priority.
  • If this request is time-sensitive, I have submitted a corresponding issue with GCP support.

Describe the feature or resource

When I tried to generate the types for AlloyDBCluster using the following command:

go run main.go generate-types \
     --service google.cloud.alloydb.v1beta \
     --api-version "alloydb.cnrm.cloud.google.com/v1beta1" \
     --resource AlloyDBCluster:Cluster \
     --resource AlloyDBInstance:Instance

I found that some of the generated types are actually empty, e.g. EncryptionInfo.

It might be better for us not to write empty types in the generated files.

Additional information

No response

Importance

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants