Add Framework Deployment to Cloudsecuritycompliance #15361
Conversation
…efinitions for Cloud Security Compliance - Introduced CloudControl.yaml with detailed properties and async operations. - Added Framework.yaml to define framework structure and properties. - Created FrameworkDeployment.yaml to manage deployment configurations and references. - Established product.yaml for Cloud Security Compliance with versioning and scopes.
…d Security Compliance
…les to enhance structure and clarity
…se VCR testing and improve configuration handling
…ynamic organization ID and category
…ions and parameters
…variables and category adjustments
…ew organization ID and enhanced configurations
…rehensive tests for cloud control functionality
…rameworkdeployment
…ycompliance-frameworkdeployment
…amework deployments
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_cloud_security_compliance_cloud_control" "primary" {
parameter_spec {
default_value {
bool_value = # value needed
number_value = # value needed
string_list_value {
values = # value needed
}
}
substitution_rules {
attribute_substitution_rule {
attribute = # value needed
}
placeholder_substitution_rule {
attribute = # value needed
}
}
validation {
allowed_values {
values {
bool_value = # value needed
number_value = # value needed
string_list_value {
values = # value needed
}
string_value = # value needed
}
}
int_range {
max = # value needed
min = # value needed
}
}
}
}
Resource: resource "google_cloud_security_compliance_framework" "primary" {
cloud_control_details {
parameters {
parameter_value {
number_value = # value needed
string_list_value {
values = # value needed
}
}
}
}
}
Resource: resource "google_cloud_security_compliance_framework_deployment" "primary" {
cloud_control_metadata {
cloud_control_details {
parameters {
parameter_value {
number_value = # value needed
string_list_value {
values = # value needed
}
}
}
}
}
deployment_state = # value needed
etag = # value needed
target_resource_config {
target_resource_creation_config {
project_creation_config {
billing_account_id = # value needed
parent = # value needed
project_display_name = # value needed
}
}
}
}
Missing service labelsThe following new resources do not have corresponding service labels:
If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels. Multiple resources addedThis PR adds multiple new resources: |
Tests analyticsTotal tests: 5663 Click here to see the affected service packages
Action takenFound 211 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🟢 Tests passed during RECORDING mode: 🔴 Tests failed when rerunning REPLAYING mode: Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made. Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Errors
|
Non-exercised tests🔴 Tests were added that are skipped in VCR:
Tests analyticsTotal tests: 0 Click here to see the affected service packages
🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR. View the build log |
2 participants
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.