You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardexpand all lines: CONTRIBUTING.md
+6-6
Original file line number
Diff line number
Diff line change
@@ -1,10 +1,10 @@
1
1
# How to become a contributor and submit your own code
2
2
3
-
This repository contains samples that the documentation on [Google Cloud Platform ][cloud] references. Samples for a client library should be added to the client repository, not this repository. (For example, the `functions` folder is reserved for samples used in [cloud.google.com/functions](cloud.google.com/functions)). If you wrote a great sample but it is not used in Google's official documentation, there are better suited places to publish it such as a [community tutorial](https://cloud.google.com/community/).
3
+
This repository contains samples that the documentation on [Google Cloud Platform ][cloud] references. Samples for a client library should be added to the client repository, not this repository. (For example, the `functions` folder is reserved for samples used in [cloud.google.com/functions](https://cloud.google.com/functions)). If you wrote a great sample but it is not used in Google's official documentation, there are better suited places to publish it such as a [community tutorial](https://cloud.google.com/community/).
4
4
5
5
## Run the tests for a single sample
6
6
7
-
1. Obtain authentication credentials. Depending on the sample, you
7
+
1. Obtain authentication credentials. Depending on the sample, you
8
8
need to enable the appropriate APIs in the [Cloud Console](https://console.cloud.google.com/apis/library).
9
9
10
10
gcloud auth application-default login
@@ -13,7 +13,7 @@ need to enable the appropriate APIs in the [Cloud Console](https://console.cloud
13
13
14
14
cd datastore/
15
15
16
-
1. Install the dependencies.
16
+
1. Install the dependencies.
17
17
18
18
npm install
19
19
@@ -24,11 +24,11 @@ need to enable the appropriate APIs in the [Cloud Console](https://console.cloud
24
24
25
25
## Adding new samples
26
26
27
-
All samples must have tests. We use `mocha` as testing framework.
27
+
All samples must have tests. We use `mocha` as testing framework.
28
28
29
29
Add a **build configuration file (`.cfg`)** for your samples in **[`.kokoro/`](https://github.com/GoogleCloudPlatform/nodejs-docs-samples/tree/master/.kokoro)**. Check existing config files for the right format.
30
30
31
-
All tests need a corresponding job file outside of GitHub. If you are a Googler, please provide the CL alongside your PR. See the internal codelab for Kokoro for details. If you don't work at Google, the person reviewing your PR will create the job config for you.
31
+
All tests need a corresponding job file outside of GitHub. If you are a Googler, please provide the CL alongside your PR. See the internal codelab for Kokoro for details. If you don't work at Google, the person reviewing your PR will create the job config for you.
32
32
33
33
### Style
34
34
@@ -44,4 +44,4 @@ directory.
44
44
[cloud]: https://cloud.google.com/
45
45
46
46
## Failing CI
47
-
`Required` tests need to pass. Tests that are not required are expected to fail, they are usually work in progress.
47
+
`Required` tests need to pass. Tests that are not required are expected to fail, they are usually work in progress.
Copy file name to clipboardexpand all lines: run/idp-sql/README.md
+2-2
Original file line number
Diff line number
Diff line change
@@ -7,7 +7,7 @@ Use it with the [End user Authentication for Cloud Run](http://cloud.google.com/
7
7
8
8
For more details on how to work with this sample read the [Google Cloud Run Node.js Samples README](https://github.com/GoogleCloudPlatform/nodejs-docs-samples/tree/master/run).
9
9
10
-
[](https://deploy.cloud.run)
10
+
[](https://deploy.cloud.run/?git_repo=https://github.com/GoogleCloudPlatform/nodejs-docs-samples&dir=run/idp-sql)
11
11
12
12
## Dependencies
13
13
@@ -49,7 +49,7 @@ Other environment variables:
49
49
50
50
* Saving credentials directly as environment variables is convenient for local testing,
51
51
but not secure for production; therefore using `CLOUD_SQL_CREDENTIALS_SECRET`
52
-
in combination with the Cloud Secrets Manager is recommended.
52
+
in combination with the Cloud Secrets Manager is recommended.
`GOOGLE_CLOUD_PROJECT=... node .`: The Cloud project with the workflow `myFirstWorkflow`.
26
26
27
27
1. Observe the results:
@@ -32,4 +32,4 @@ This sample shows how to execute a Cloud Workflow and wait for the workflow exec
32
32
["Wednesday","Wednesday Night Wars","Wednesday 13","Wednesday Addams","Wednesday Campanella","Wednesdayite","Wednesday Martin","Wednesday Campanella discography","Wednesday Night Hockey (American TV program)","Wednesday Morning, 3 A.M."]
0 commit comments