Merge pull request #156 from spowelljr/updateMocking

Use mock registry if `MOCK_GOOGLE_TOKEN` is true

Author: medyagh

server.go

@@ -118,19 +118,25 @@ func createPullSecret(clientset *kubernetes.Clientset, ns *corev1.Namespace, cre
 		}
 	}
 
-	// The MOCK_GOOGLE_TOKEN env var prevents using credentials to fetch the token. Instead the token will be mocked.
+	registries := append(gcr_config.DefaultGCRRegistries[:], gcr_config.DefaultARRegistries[:]...)
+
+	// The MOCK_GOOGLE_TOKEN env var prevents using credentials to fetch the
+	// token. Instead the token will be mocked. It also sets a mock registry
+	// due to pulls to Artifact Registry for publicly available images with
+	// mock credentials causing unauthorized errors. See:
+	// https://github.com/kubernetes/minikube/issues/19714
 	mockToken, _ := strconv.ParseBool(os.Getenv("MOCK_GOOGLE_TOKEN"))
 	var token *oauth2.Token
 	if mockToken {
 		token = &oauth2.Token{AccessToken: "mock_access_token"}
+		registries = []string{"mock-registry"}
 	} else {
 		token, err = creds.TokenSource.Token()
 		if err != nil {
 			return err
 		}
 	}
 	var dockercfg string
-	registries := append(gcr_config.DefaultGCRRegistries[:], gcr_config.DefaultARRegistries[:]...)
 	for _, reg := range registries {
 		dockercfg += fmt.Sprintf(`"https://%s":{"username":"oauth2accesstoken","password":"%s","email":"none"},`, reg, token.AccessToken)
 	}