fix: update debug skip probes annotation to be Kubernetes valid annotation (#9831)

Author: Automaat

docs-v2/content/en/docs/workflows/debug.md

@@ -391,13 +391,13 @@ an event that can be used by tools like IDEs to establish a debug session.
     being terminated and restarted.
 
 	The probe timeout value can be set on a per-podspec basis by setting
-	a `debug.cloud.google.com/probe/timeouts` annotation on the podspec's metadata
+	a `debug.cloud.google.com/probe-timeouts` annotation on the podspec's metadata
 	with a valid duration (see [Go's time.ParseDuration()](https://pkg.go.dev/time#ParseDuration)).
     This probe timeout-rewriting can be skipped entirely by using `skip`.  For example:
     ```yaml
     metadata:
       annotations:
-        debug.cloud.google.com/probe/timeouts: skip
+        debug.cloud.google.com/probe-timeouts: skip
     spec: ...
     ```
 

pkg/skaffold/debug/types/types.go

@@ -27,7 +27,7 @@ const (
 
 	// DebugProbesAnnotation is the name of the podspec annotation that disables rewriting of probe timeouts.
 	// The annotation value should be `skip`.
-	DebugProbeTimeouts = "debug.cloud.google.com/probe/timeouts"
+	DebugProbeTimeouts = "debug.cloud.google.com/probe-timeouts"
 )
 
 // ContainerDebugConfiguration captures debugging information for a specific container.

pkg/skaffold/kubernetes/debugging/transform_test.go

@@ -229,7 +229,7 @@ func TestRewriteProbes(t *testing.T) {
 			name: "skips pod with skip-probes annotation",
 			input: v1.Pod{
 				TypeMeta:   metav1.TypeMeta{APIVersion: v1.SchemeGroupVersion.Version, Kind: "Pod"},
-				ObjectMeta: metav1.ObjectMeta{Name: "podname", Annotations: map[string]string{"debug.cloud.google.com/probe/timeouts": `skip`}},
+				ObjectMeta: metav1.ObjectMeta{Name: "podname", Annotations: map[string]string{"debug.cloud.google.com/probe-timeouts": `skip`}},
 				Spec: v1.PodSpec{Containers: []v1.Container{{
 					Name:          "name1",
 					Image:         "image1",
@@ -240,15 +240,15 @@ func TestRewriteProbes(t *testing.T) {
 			name: "processes pod with probes annotation with explicit timeout",
 			input: v1.Pod{
 				TypeMeta:   metav1.TypeMeta{APIVersion: v1.SchemeGroupVersion.Version, Kind: "Pod"},
-				ObjectMeta: metav1.ObjectMeta{Name: "podname", Annotations: map[string]string{"debug.cloud.google.com/probe/timeouts": `1m`}},
+				ObjectMeta: metav1.ObjectMeta{Name: "podname", Annotations: map[string]string{"debug.cloud.google.com/probe-timeouts": `1m`}},
 				Spec: v1.PodSpec{Containers: []v1.Container{{
 					Name:          "name1",
 					Image:         "image1",
 					LivenessProbe: &v1.Probe{ProbeHandler: v1.ProbeHandler{HTTPGet: &v1.HTTPGetAction{Path: "/", Port: intstr.FromInt(8080)}}, TimeoutSeconds: 1}}}}},
 			changed: false,
 			result: v1.Pod{
 				TypeMeta:   metav1.TypeMeta{APIVersion: v1.SchemeGroupVersion.Version, Kind: "Pod"},
-				ObjectMeta: metav1.ObjectMeta{Name: "podname", Annotations: map[string]string{"debug.cloud.google.com/probe/timeouts": `1m`}},
+				ObjectMeta: metav1.ObjectMeta{Name: "podname", Annotations: map[string]string{"debug.cloud.google.com/probe-timeouts": `1m`}},
 				Spec: v1.PodSpec{Containers: []v1.Container{{
 					Name:          "name1",
 					Image:         "image1",
@@ -258,15 +258,15 @@ func TestRewriteProbes(t *testing.T) {
 			name: "processes pod with probes annotation with invalid timeout",
 			input: v1.Pod{
 				TypeMeta:   metav1.TypeMeta{APIVersion: v1.SchemeGroupVersion.Version, Kind: "Pod"},
-				ObjectMeta: metav1.ObjectMeta{Name: "podname", Annotations: map[string]string{"debug.cloud.google.com/probe/timeouts": `on`}},
+				ObjectMeta: metav1.ObjectMeta{Name: "podname", Annotations: map[string]string{"debug.cloud.google.com/probe-timeouts": `on`}},
 				Spec: v1.PodSpec{Containers: []v1.Container{{
 					Name:          "name1",
 					Image:         "image1",
 					LivenessProbe: &v1.Probe{ProbeHandler: v1.ProbeHandler{HTTPGet: &v1.HTTPGetAction{Path: "/", Port: intstr.FromInt(8080)}}, TimeoutSeconds: 1}}}}},
 			changed: false,
 			result: v1.Pod{
 				TypeMeta:   metav1.TypeMeta{APIVersion: v1.SchemeGroupVersion.Version, Kind: "Pod"},
-				ObjectMeta: metav1.ObjectMeta{Name: "podname", Annotations: map[string]string{"debug.cloud.google.com/probe/timeouts": `on`}},
+				ObjectMeta: metav1.ObjectMeta{Name: "podname", Annotations: map[string]string{"debug.cloud.google.com/probe-timeouts": `on`}},
 				Spec: v1.PodSpec{Containers: []v1.Container{{
 					Name:          "name1",
 					Image:         "image1",