Skip to content

Commit b833ae9

Browse files
authored
Prevent infinite request loop with srcset in image (#6341)
Prevent infinite request loop with srcset in image. Closes #6332
1 parent 0db6729 commit b833ae9

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

packages/core/src/dom_components/view/ComponentImageView.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,9 +95,12 @@ export default class ComponentImageView<TComp extends ComponentImage = Component
9595
}
9696

9797
onError() {
98-
const fallback = this.model.getSrcResult({ fallback: true });
98+
const { model, el } = this;
99+
const fallback = model.getSrcResult({ fallback: true });
99100
if (fallback) {
100-
this.el.src = fallback;
101+
// Remove srcset to prevent error loop on src update #6332
102+
if (el.srcset) el.srcset = '';
103+
el.src = fallback;
101104
}
102105
}
103106

0 commit comments

Comments
 (0)