Skip to content

Use more specific node input indexing when displaying invalid input errors#3415

Merged
Keavon merged 3 commits into
masterfrom
improve-invalid-branch
Dec 18, 2025
Merged

Use more specific node input indexing when displaying invalid input errors#3415
Keavon merged 3 commits into
masterfrom
improve-invalid-branch

Conversation

@adamgerhant
Copy link
Copy Markdown
Collaborator

@adamgerhant adamgerhant commented Nov 24, 2025

Does not display invalid inputs in the property panel and only shows invalid inputs for the inputs which are invalid, not all.

Fixes invalid input indexing for automatically converted Into nodes.

After:
chrome_Z2GRCCfMUR
Before:
chrome_VA7eHA57sa

@Keavon Keavon force-pushed the improve-invalid-branch branch from 85e6696 to 118c587 Compare November 24, 2025 11:02
@adamgerhant adamgerhant marked this pull request as draft November 24, 2025 11:28
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) November 24, 2025 11:29 Inactive
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) November 24, 2025 21:13 Inactive
@adamgerhant adamgerhant force-pushed the improve-invalid-branch branch from 79af961 to 6e505de Compare November 25, 2025 18:58
@adamgerhant adamgerhant marked this pull request as ready for review November 25, 2025 19:00
@adamgerhant adamgerhant force-pushed the improve-invalid-branch branch from 6e505de to b9b113b Compare November 25, 2025 19:01
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) November 25, 2025 19:03 Inactive
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) November 25, 2025 19:17 Inactive
@Keavon Keavon force-pushed the improve-invalid-branch branch from b9b113b to c623e79 Compare December 18, 2025 09:50
@Keavon Keavon changed the title Reduce displayed invalid inputs Use more specific node input indexing when displaying invalid input errors Dec 18, 2025
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) December 18, 2025 09:54 Inactive
Comment thread node-graph/graph-craft/src/proto.rs Outdated
Comment thread node-graph/graph-craft/src/document.rs Outdated
Comment thread node-graph/graph-craft/src/proto.rs Outdated
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) December 18, 2025 10:18 Inactive
@adamgerhant adamgerhant force-pushed the improve-invalid-branch branch from 55903c9 to 41ac52d Compare December 18, 2025 10:33
@Keavon Keavon enabled auto-merge (squash) December 18, 2025 10:34
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) December 18, 2025 10:38 Inactive
@Keavon Keavon merged commit 6733a24 into master Dec 18, 2025
4 checks passed
@Keavon Keavon deleted the improve-invalid-branch branch December 18, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants