Port the ME buses and hatches to MUI2 #2824

Zorbatron · 2025-06-11T15:39:37Z

What

Ports all of the ME buses and hatches to use MUI2.
ME outputs can buffer 2^63 - 1 of a stack per slot now.
Adds a variable refresh rate to all ME parts (no way to change for the output parts, will be when I port then to MUI2).
Adds a minimum stack size filter to the stocking input parts.
Refactors how JEI recipe transfers are handled in GT GUIs, and makes the crafting station only accept crafting table recipes from JEI.
You can now set the config of the ME input parts from JEI with the + button.
Show if the ME part can connect from all sides in TOP/WAILA.
Fix MUI2 clearing popup panel SyncHandlers if the screen is being replaced (like viewing a JEI recipe), instead of only when closing.

Outcome

More MUI2 and makes the ME input parts better.

Additional Information

Closes #2571 and #2482

In progress

…ement actual item setting and clearing.

…ll wacked out.

…f the world is exited too fast.

…g is wacked and the flow is missing from the main panel's children but this is a problem for tomorrow!!

… opened and then it went offline (unwanted text wrapping)

ALongStringOfNumbers

One thing I noticed is that mod name tooltips are not shown on items/fluids in the ME inputs (Didn't check the outputs)

Should the ME fluid output (Don't know if it happens with items) be able to store fluid inside of it while it is offline?

Thoughts on allowing the item inputs to take an Oredict entry for a slot? Probably would be a bit annoying, but could be nice to have.

Using the Recipe Transfer from JEI allows for transfering pages that most likely should not be possible, like the material tree and the ore processing chart.

The Recipe Transfer Button in our JEI GUIs (specifically machines) does not active a JEI exclusion area, and so somewhat overlaps with items in the search pane. Is that something we can fix, either by moving the button inward, or adding an exclusion area for it?

It would be nice if the shift/control/alt key combos worked for scrolling fluid worked for in the Input Hatch config slots, like in Fluid Regulator when it is in Supply Exact mode. Plus having the scrolling key combo information added to the tooltip.

src/main/java/gregtech/api/mui/widget/appeng/AEConfigSlot.java

ALongStringOfNumbers · 2025-09-20T03:12:49Z

...regtech/common/metatileentities/multi/multiblockpart/appeng/MetaTileEntityMEOutputHatch.java

+                    FluidTooltipUtil.handleFluidTooltip(tooltip, stack);
+                }));
+        text.space();
+        text.addLine(KeyUtil.number(TextFormatting.WHITE, wrappedStack.getStackSize(), "x"));


This should be in mB or B or L, rather than x
Also, could we get the fluid name here, so it is seen quicker than hovering?

Right now it doesn't have the item/fluid name along with the amount since it looks ugly if the text has to wrap, but I might be able to solve it by making large numbers use scientific notation and wrap the text within the row.

you could have the amounts listed below the item name, maybe cut the name if it's too long, i think we have a method for that

...gregtech/common/metatileentities/multi/multiblockpart/appeng/MetaTileEntityMEOutputBase.java

ALongStringOfNumbers · 2025-09-20T03:37:55Z

...a/gregtech/common/metatileentities/multi/multiblockpart/appeng/MetaTileEntityMEInputBus.java

+                        .child(IKey.lang("gregtech.machine.me.settings.button")
+                                .asWidget()
+                                .heightRel(1.0f)))
+                .child(IKey.lang("gregtech.machine.me.settings.refresh_rate")


Could this get a time specification? IE ticks, seconds, etc

ALongStringOfNumbers · 2025-09-20T04:11:09Z

src/main/java/gregtech/api/mui/sync/appeng/AESyncHandler.java

+                }
+            }
+            case setConfigID -> {
+                int index = buf.readVarInt();


Do we ever need to check if the index is within the number of slots? I see a lot of just blind reading and using the index, and I was wondering if there was a possibility that it would ever be out of bounds of the number of slots.

src/main/java/gregtech/api/mui/sync/appeng/AESyncHandler.java

ALongStringOfNumbers · 2025-09-20T04:46:31Z

src/main/java/gregtech/api/mui/sync/appeng/AEItemSyncHandler.java

+    }
+
+    @Override
+    public IRecipeTransferError receiveRecipe(@NotNull IRecipeLayout recipeLayout, boolean maxTransfer,


Using the recipe transfer from JEI clears the existing config to add in the ingredients of the recipe output. In my opinion it would be better to combine the existing config with the input ingredients of the target itemstack. Open to some discussion here.

ALongStringOfNumbers · 2025-09-20T05:08:23Z

src/main/java/gregtech/api/mui/sync/appeng/AEFluidSyncHandler.java

+    }
+
+    @Override
+    public IRecipeTransferError receiveRecipe(@NotNull IRecipeLayout recipeLayout, boolean maxTransfer,


Can this be made to work with fluid containers in a recipe input? EG, our treated wood recipe with a bucket of creosote. Could the recipe transfer take the contained fluid in a fluid handler and then use that?

...a/gregtech/common/metatileentities/multi/multiblockpart/appeng/MetaTileEntityMEInputBus.java

src/main/java/gregtech/api/mui/widget/appeng/fluid/AEFluidConfigSlot.java

…lines

Fix no newline after the fluid mol tooltip

Zorbatron · 2025-09-22T00:55:02Z

One thing I noticed is that mod name tooltips are not shown on items/fluids in the ME inputs (Didn't check the outputs)
Fixed and I'm upstreaming my fix to MUI2.

Zorbatron · 2025-09-22T02:41:19Z

About the ore dict slot, I think it would be better if it was for all slots, so it would auto pull the first 16 items that matched the ore dict. But, that is something that can already be done by creating a subnet with the bus, and having an ore dict storage bus connected to the main network.

…es and takes items from hatches so badly!1!1!)

…reen register RecipeSyncHandler's to GregTechGuiScreen

ghzdude · 2025-10-03T22:59:10Z

src/main/java/gregtech/client/IsGuiActuallyClosing.java

+package gregtech.client;
+
+public class IsGuiActuallyClosing {
+
+    public static boolean isGuiActuallyClosing;
+}


what's the purpose of this class and its associated mixin?

CleanroomMC/ModularUI#153

okay, in that case leave a todo here and in the mixin to remove it once our mui2 dep is updated

# Conflicts: # .gitignore # src/main/java/gregtech/api/mui/GTGuis.java # src/main/java/gregtech/api/mui/sync/GTFluidSyncHandler.java # src/main/java/gregtech/api/util/FluidTooltipUtil.java # src/main/java/gregtech/api/util/JEIUtil.java # src/main/java/gregtech/common/gui/widget/appeng/slot/AEItemConfigSlot.java # src/main/java/gregtech/common/gui/widget/appeng/slot/AEItemDisplayWidget.java # src/main/java/gregtech/common/metatileentities/workbench/CraftingRecipeLogic.java # src/main/resources/mixins.gregtech.mui2.json

Zorbatron added 30 commits May 11, 2025 01:10

start on input bus

4e2b59e

Merge branch 'master' into zb/me-hatch-mui2

7ace9e0

Item Input: extra slot, circuit, arrow

b911ee4

Item Input: extra slot, circuit, arrow

4ea4d7a

In progress

Finalize AEHostablePart split

035b97b

Fix TOP/WAILA providers

86431e7

Wrong super call from ctrl c+v :icant:

673a818

Add if the part can connect from all sides to TOP/WAILA

292edfe

Start on config and display widget

29b3661

Sprinkle in some nullables

89d276a

Item slot jei dragging (ish, just logging for now 🧌)

0d62422

Use the probably more proper tooltip making method

bc1ccf1

Merge branch 'master' into zb/me-hatch-mui2

1118599

This doesn't need to be dynamic

2a9d4ba

JEI dropping works (no item rendering yet)

1027d09

Chat we're rending items now :caught:

05e49ec

Item tooltips (not dynamic oops)

b38b8a6

Extract the sync handler out pt1

2c3b55f

Sync work pt2

501314b

Sync work pt3 and tooltips that actually work

009447e

Remove redundant code, remove MUI0 code from ME Input Buses, and impl…

ba1c854

…ement actual item setting and clearing.

Merge branch 'master' into zb/me-hatch-mui2

14f6f12

Scrolling (almost why no sync ug)

58b0362

Fix the cache not being set to a copy which caused scrolling to get a…

c2da636

…ll wacked out.

Set MTE dirty when setting the config to prevent it from being lost i…

9e70ef5

…f the world is exited too fast.

Stocking auto pull

ff3e645

Fluid display slot

727566d

Fluid config slot

30de112

More fluid stuff, a couple fixes. Um it almost works but the renderin…

6cedd49

…g is wacked and the flow is missing from the main panel's children but this is a problem for tomorrow!!

wowie spotless

dae9d07

Fix the extra slot item in input buses not dropping

681adcd

Zorbatron marked this pull request as ready for review September 20, 2025 02:39

Zorbatron requested a review from a team as a code owner September 20, 2025 02:39

Fix the width of the online text widget being too thin if the gui was…

debdba8

… opened and then it went offline (unwanted text wrapping)

ALongStringOfNumbers reviewed Sep 20, 2025

View reviewed changes

Zorbatron added 8 commits September 20, 2025 17:37

Use L instead of x for the amount in ME output hatches

c4564be

Revert nullability change to IntCircuitIngredient

d8d2a82

Address TODO in GTUtility

64bca50

Check NBT in WrappedItemStack#equals

654e3f4

Fix the amount text and always show the scroll tooltip

4002e42

Add line separator between fluid/item description and scroll control …

e4666ef

…lines

Add mod name to item tooltips

274c4b9

Add the mod name to all MUI2 item slots and our fluid slots

0656f02

Fix no newline after the fluid mol tooltip

Zorbatron and others added 12 commits September 22, 2025 14:41

Input parts code dedup pt1

cb63af8

Fix handler init stuff

9b3e7fc

Circuit slot in input hatches

2d2c600

Actually add the circuit handler to the multiblock abilities list

ecaeafc

Fix notifiables

e02acdd

addline and lang

0a4bf36

Fix stocking hatches duping like crazy (Agh I want to redo how ARL se…

1ce17aa

…es and takes items from hatches so badly!1!1!)

visibility change of getAEHandler

e929025

Add fluid name (fogor) to tooltip on amount popup and mod name

a62f2f2

Support longs in input parts (only in buffering)

5f213f9

create RecipeSyncHandler to simplify recipe transfer in GregTechGuiSc…

97e6990

…reen register RecipeSyncHandler's to GregTechGuiScreen

remove mixins that are now unused

4f43375

ghzdude reviewed Oct 3, 2025

View reviewed changes

Zorbatron added 2 commits November 29, 2025 00:57

Just get it compiling again

013a3b5

Port the ME buses and hatches to MUI2 #2824

Are you sure you want to change the base?

Port the ME buses and hatches to MUI2 #2824

Uh oh!

Conversation

Zorbatron commented Jun 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

Outcome

Additional Information

Uh oh!

ALongStringOfNumbers left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Zorbatron commented Sep 22, 2025

Uh oh!

Zorbatron commented Sep 22, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Zorbatron commented Jun 11, 2025 •

edited

Loading