Fix Issue with MapIngredient's Equals Impl #2881
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
check gt recipe input and tag in equals impl remove MapItemStackNBTIngredient.java as it seemed to be redundant
make test more specific to chem bath recipe map
M-W-K
approved these changes
Nov 11, 2025
set regular input with null nbt not sure why an ingredient is declared outside of the for loop, so i removed it hope it doesn't break anything
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes an issue causing a very small subset of recipes to not be able to run. Specifically, the wool dyeing recipes in the Chemical Bath.
Implementation Details
the previous impl failed to account for when both
gtRecipeInputsare null, it would returnfalsedeleted
MapItemStackNBTIngredientbecause it's redundantadded tests for this issue
Outcome
people can dye wool again at a terrible rate
Potential Compatibility Issues
hope this doesn't break any other recipe
idk how this was working in the first place