Update design document and tweak some other things.

Author: GregUtas

docs/RSC-Software-Design.pdf

@@ -9,7 +9,8 @@
       "installRoot": "${projectDir}\\out\\install\\${name}",
       "cmakeCommandArgs": "",
       "buildCommandArgs": "",
-      "ctestCommandArgs": ""
+      "ctestCommandArgs": "",
+      "enableMicrosoftCodeAnalysis": true
     },
     {
       "name": "x64-Release",
@@ -20,7 +21,8 @@
       "cmakeCommandArgs": "",
       "buildCommandArgs": "",
       "ctestCommandArgs": "",
-      "inheritEnvironments": [ "msvc_x64_x64" ]
+      "inheritEnvironments": [ "msvc_x64_x64" ],
+      "enableMicrosoftCodeAnalysis": true
     },
     {
       "name": "x86-Debug",
@@ -30,7 +32,8 @@
       "installRoot": "${projectDir}\\out\\install\\${name}",
       "buildCommandArgs": "",
       "ctestCommandArgs": "",
-      "inheritEnvironments": [ "msvc_x86" ]
+      "inheritEnvironments": [ "msvc_x86" ],
+      "enableMicrosoftCodeAnalysis": true
     },
     {
       "name": "x86-Release",
@@ -40,7 +43,8 @@
       "installRoot": "${projectDir}\\out\\install\\${name}",
       "buildCommandArgs": "",
       "ctestCommandArgs": "",
-      "inheritEnvironments": [ "msvc_x86" ]
+      "inheritEnvironments": [ "msvc_x86" ],
+      "enableMicrosoftCodeAnalysis": true
     },
     {
       "name": "x64-Clang-Debug",
@@ -51,7 +55,8 @@
       "cmakeCommandArgs": "",
       "buildCommandArgs": "",
       "ctestCommandArgs": "",
-      "inheritEnvironments": [ "clang_cl_x64_x64" ]
+      "inheritEnvironments": [ "clang_cl_x64_x64" ],
+      "enableClangTidyCodeAnalysis": true
     },
     {
       "name": "WSL-GCC-Debug",
@@ -64,7 +69,8 @@
       "buildCommandArgs": "",
       "ctestCommandArgs": "",
       "inheritEnvironments": [ "linux_x64" ],
-      "wslPath": "${defaultWSLPath}"
+      "wslPath": "${defaultWSLPath}",
+      "enableClangTidyCodeAnalysis": true
     }
   ]
 }

src/CMakeSettings.json

@@ -2103,6 +2103,17 @@ word Editor::DeleteSpecialFunction(const CodeWarning& log)
 
 //------------------------------------------------------------------------------
 
+word Editor::DemoteFunction(const CodeWarning& log)
+{
+   Debug::ft("Editor.DemoteFunction");
+
+   //  Move the function to the derived class specified in the log.
+   //
+   return Unimplemented();
+}
+
+//------------------------------------------------------------------------------
+
 void Editor::Display(ostream& stream,
    const string& prefix, const Flags& options) const
 {
@@ -3821,6 +3832,8 @@ word Editor::FixWarning(const CodeWarning& log)
       return FixDatas(log);
    case FunctionShouldBeStatic:
       return FixFunctions(log);
+   case FunctionCouldBeDemoted:
+      return DemoteFunction(log);
    case NoEndlineAtEndOfFile:
       return AppendEndline();
    case AutoCopiesReference:

src/ct/Editor.cpp

@@ -174,6 +174,7 @@ class Editor : public Lexer
    static word ChangeMemberToFree(const CodeWarning& log);
    word ChangeOperator(const CodeWarning& log);
    word ChangeStructToClass(const CodeWarning& log);
+   word DemoteFunction(const CodeWarning& log);
    word EraseAdjacentSpaces(const CodeWarning& log);
    word EraseAccessControl(const CodeWarning& log);
    word EraseBlankLine(const CodeWarning& log);