Skip to content

refactor!: use pod ip to set up --rpc-server-addr in datanode and flownode #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2025
Merged

refactor!: use pod ip to set up --rpc-server-addr in datanode and flownode #335

merged 1 commit into from
Oct 15, 2025

Conversation

@zyy17
Copy link
Collaborator

@zyy17 zyy17 commented Oct 15, 2025 •
edited
Loading

What's changed

  1. Use pod ip to set up --server-addr in datanode and flownode;
  2. Remove some unused arguments of initializer;

@zyy17 zyy17 requested a review from daviderli614 October 15, 2025 08:57
@zyy17 zyy17 force-pushed the refactor/use-accurate-server-addr branch from 86649d9 to 53bb65a Compare October 15, 2025 09:01
@github-actions github-actions bot added size/S and removed size/XS labels Oct 15, 2025
@zyy17 zyy17 enabled auto-merge (squash) October 15, 2025 09:18
@zyy17 zyy17 force-pushed the refactor/use-accurate-server-addr branch from 53bb65a to e45c103 Compare October 15, 2025 13:31
@github-actions github-actions bot added size/M and removed size/S labels Oct 15, 2025
@zyy17 zyy17 force-pushed the refactor/use-accurate-server-addr branch from e45c103 to 9df1783 Compare October 15, 2025 13:32
@zyy17 zyy17 force-pushed the refactor/use-accurate-server-addr branch from 9df1783 to b78fbdd Compare October 15, 2025 15:16
@zyy17 zyy17 changed the title refactor: use pod ip instead of service name to make it consistent refactor!: use pod ip to set up --server-addr in datanode and flownode Oct 15, 2025
@zyy17 zyy17 changed the title refactor!: use pod ip to set up --server-addr in datanode and flownode refactor!: use pod ip to set up --server-addr in datanode and flownode Oct 15, 2025
@zyy17 zyy17 changed the title refactor!: use pod ip to set up --server-addr in datanode and flownode refactor!: use pod ip to set up --rpc-server-addr in datanode and flownode Oct 15, 2025
@zyy17 zyy17 merged commit ec74bee into GreptimeTeam:main Oct 15, 2025
11 checks passed
@daviderli614 daviderli614 mentioned this pull request Oct 29, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daviderli614 daviderli614 daviderli614 approved these changes

Assignees

No one assigned

Labels

size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zyy17 @daviderli614