Skip to content

Commit 15935ee

Browse files
committed
fix
Signed-off-by: Zhenchi <[email protected]>
1 parent d087799 commit 15935ee

File tree

4 files changed

+15
-19
lines changed

4 files changed

+15
-19
lines changed

src/common/meta/src/ddl.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,8 @@ pub mod drop_flow;
4343
pub mod drop_table;
4444
pub mod drop_view;
4545
pub mod flow_meta;
46-
pub mod table_meta;
4746
pub mod repartition;
47+
pub mod table_meta;
4848
#[cfg(any(test, feature = "testing"))]
4949
pub mod test_util;
5050
#[cfg(test)]

src/common/meta/src/ddl/repartition/plan.rs

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -101,15 +101,9 @@ impl PartitionRuleDiff {
101101
#[derive(Debug, Clone, Serialize, Deserialize, PartialEq, Eq)]
102102
pub enum PartitionChange {
103103
/// Split one region into multiple target regions.
104-
Split {
105-
from: RegionId,
106-
to: Vec<RegionId>,
107-
},
104+
Split { from: RegionId, to: Vec<RegionId> },
108105
/// Merge multiple regions into one target region.
109-
Merge {
110-
from: Vec<RegionId>,
111-
to: RegionId,
112-
},
106+
Merge { from: Vec<RegionId>, to: RegionId },
113107
/// No-op placeholder for future operations (e.g. rule rewrite).
114108
Unsupported,
115109
}

src/common/meta/src/ddl/repartition/procedure.rs

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,11 @@ use strum::AsRefStr;
4040
use table::table_reference::TableReference;
4141
use uuid::Uuid;
4242

43-
use crate::ddl::repartition::{PartitionRuleDiff, PlanGroup, PlanGroupId, RepartitionPlan, ResourceDemand};
44-
use crate::ddl::utils::map_to_procedure_error;
4543
use crate::ddl::DdlContext;
44+
use crate::ddl::repartition::{
45+
PartitionRuleDiff, PlanGroup, PlanGroupId, RepartitionPlan, ResourceDemand,
46+
};
47+
use crate::ddl::utils::map_to_procedure_error;
4648
use crate::error::Result;
4749
use crate::lock_key::{CatalogLock, SchemaLock, TableLock};
4850

@@ -138,7 +140,7 @@ impl RepartitionProcedure {
138140
async fn on_collect_subprocedures(&mut self, _ctx: &ProcedureContext) -> Result<Status> {
139141
self.data
140142
.succeeded_groups
141-
.extend(self.data.pending_groups.drain(..));
143+
.append(&mut self.data.pending_groups);
142144

143145
self.data.state = RepartitionState::Finalize;
144146
Ok(Status::executing(true))
@@ -162,8 +164,10 @@ impl RepartitionProcedure {
162164
plan.groups.push(PlanGroup::new(group_id));
163165
}
164166

165-
let mut demand = ResourceDemand::default();
166-
demand.new_regions = plan.groups.len() as u32;
167+
let demand = ResourceDemand {
168+
new_regions: plan.groups.len() as u32,
169+
..Default::default()
170+
};
167171
plan.resource_demand = demand;
168172

169173
Ok((plan, diff, demand))
@@ -207,9 +211,7 @@ impl Procedure for RepartitionProcedure {
207211
RepartitionState::Prepare => self.on_prepare().await,
208212
RepartitionState::AllocateResources => self.on_allocate_resources().await,
209213
RepartitionState::DispatchSubprocedures => self.on_dispatch_subprocedures().await,
210-
RepartitionState::CollectSubprocedures => {
211-
self.on_collect_subprocedures(ctx).await
212-
}
214+
RepartitionState::CollectSubprocedures => self.on_collect_subprocedures(ctx).await,
213215
RepartitionState::Finalize => self.on_finalize().await,
214216
RepartitionState::Finished => Ok(Status::done()),
215217
};
@@ -298,7 +300,7 @@ pub struct RepartitionTask {
298300
}
299301

300302
impl RepartitionTask {
301-
fn table_ref(&self) -> TableReference {
303+
fn table_ref(&self) -> TableReference<'_> {
302304
TableReference {
303305
catalog: &self.catalog_name,
304306
schema: &self.schema_name,

src/common/meta/src/ddl_manager.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,11 +31,11 @@ use crate::ddl::create_flow::CreateFlowProcedure;
3131
use crate::ddl::create_logical_tables::CreateLogicalTablesProcedure;
3232
use crate::ddl::create_table::CreateTableProcedure;
3333
use crate::ddl::create_view::CreateViewProcedure;
34-
use crate::ddl::repartition::{RepartitionProcedure, RepartitionTask};
3534
use crate::ddl::drop_database::DropDatabaseProcedure;
3635
use crate::ddl::drop_flow::DropFlowProcedure;
3736
use crate::ddl::drop_table::DropTableProcedure;
3837
use crate::ddl::drop_view::DropViewProcedure;
38+
use crate::ddl::repartition::{RepartitionProcedure, RepartitionTask};
3939
use crate::ddl::truncate_table::TruncateTableProcedure;
4040
use crate::ddl::{DdlContext, utils};
4141
use crate::error::{

0 commit comments

Comments
 (0)