Minor code cleanup

Author: Grub4K

VDFparse.Core/VDFFile.cs

@@ -10,7 +10,8 @@ public interface IVDFFileReader
 
 public class VDFFile
 {
-    private static List<IVDFFileReader> Readers = new List<IVDFFileReader>(){
+    private static List<IVDFFileReader> VdfFileReaders = new()
+    {
         new PackageInfoReaderOld(),
         new PackageInfoReader(),
         new AppInfoReader(),
@@ -22,29 +23,27 @@ public class VDFFile
 
     public void Read(string filename)
     {
-        using (var fs = new FileStream(filename, FileMode.Open, FileAccess.Read, FileShare.ReadWrite))
-        {
-            Read(fs);
-        }
+        using var fs = new FileStream(filename, FileMode.Open, FileAccess.Read);
+
+        Read(fs);
     }
 
     public void Read(Stream stream)
     {
-        using (var reader = new BinaryReader(stream))
+        using var reader = new BinaryReader(stream);
+
+        var magic = reader.ReadUInt32();
+        Universe = (EUniverse)reader.ReadUInt32();
+        foreach (var vdfFileReader in VdfFileReaders)
         {
-            var magic = reader.ReadUInt32();
-            Universe = (EUniverse)reader.ReadUInt32();
-            foreach (var reader_sub in Readers)
+            if (magic == vdfFileReader.Magic)
             {
-                if (magic == reader_sub.Magic)
-                {
-                    Datasets = reader_sub.Read(reader);
-                    return;
-                }
+                Datasets = vdfFileReader.Read(reader);
+                return;
             }
-            var hexHeader = Convert.ToHexString(BitConverter.GetBytes(magic));
-            throw new InvalidDataException($"Unknown header: {hexHeader}");
         }
+
+        throw new InvalidDataException($"Unknown header: {magic:X8}");
     }
 
     public Dataset? FindByID(uint id)

VDFparse.Core/infoFiles/AppInfo.cs

@@ -1,6 +1,7 @@
 using System.Collections.ObjectModel;
 
 namespace VDFparse;
+
 public class AppInfoReader : IVDFFileReader
 {
     public uint Magic { get => 0x07_56_44_27; }
@@ -20,7 +21,7 @@ public List<Dataset> Read(BinaryReader reader)
                 ID: id,
                 Size: reader.ReadUInt32(),
                 InfoState: reader.ReadUInt32(),
-                LastUpdated: DateTimeFromUnixTime(reader.ReadUInt32()),
+                LastUpdated: DateTimeFromUnixTimestamp(reader.ReadUInt32()),
                 Token: reader.ReadUInt64(),
                 Hash: new ReadOnlyCollection<byte>(reader.ReadBytes(20)),
                 ChangeNumber: reader.ReadUInt32(),
@@ -29,9 +30,10 @@ public List<Dataset> Read(BinaryReader reader)
         }
     }
 
-    public static DateTime DateTimeFromUnixTime(uint unixTime)
+    private static DateTime UnixBaseTime { get; } = new DateTime(1970, 1, 1);
+    private static DateTime DateTimeFromUnixTimestamp(uint unixTime)
     {
-        return new DateTime(1970, 1, 1, 0, 0, 0, 0, DateTimeKind.Utc).AddSeconds(unixTime);
+        return UnixBaseTime.AddSeconds(unixTime);
     }
 }
 

VDFparse.Core/infoFiles/PackageInfo.cs

@@ -1,6 +1,3 @@
-using System.Collections.ObjectModel;
-
-
 namespace VDFparse;
 
 public class PackageInfoReader : IVDFFileReader
@@ -9,18 +6,16 @@ public class PackageInfoReader : IVDFFileReader
 
     public List<Dataset> Read(BinaryReader reader)
     {
-        var Datasets = new List<Dataset>();
+        var datasets = new List<Dataset>();
         while (true)
         {
             var id = reader.ReadUInt32();
             if (id == 0xFFFFFFFF)
-            {
-                return Datasets;
-            }
+                return datasets;
 
-            Datasets.Add(new Dataset(
+            datasets.Add(new Dataset(
                 ID: id,
-                Hash: new ReadOnlyCollection<byte>(reader.ReadBytes(20)),
+                Hash: Array.AsReadOnly(reader.ReadBytes(20)),
                 Token: IsOldVersion ? 0 : reader.ReadUInt64(),
                 ChangeNumber: reader.ReadUInt32(),
                 Data: KVParser.Parse(reader)