Skip to content

Commit dcd11e9

Browse files
authored
fix: address some lint violations (#219)
1 parent c7b987d commit dcd11e9

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

.rubocop.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ Metrics/ParameterLists:
4949
Max: 5
5050
CountKeywordArgs: false
5151
Metrics/LineLength:
52-
Max: 100
52+
Max: 120
5353
Exclude:
5454
- lib/apollo-federation/tracing/proto/apollo_pb.rb
5555

lib/apollo-federation/schema.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ def self.included(klass)
1212
end
1313

1414
module CommonMethods
15-
DEFAULT_LINK_NAMESPACE = 'federation'.freeze
15+
DEFAULT_LINK_NAMESPACE = 'federation'
1616

1717
def federation(version: '1.0', link: {})
1818
@federation_version = version

spec/apollo-federation/schema_spec.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
expect(schema.federation_version).to eq('1.0')
1515
end
1616

17-
it 'returns the specified version when set' do
17+
it 'returns the specified version when set to 2.0' do
1818
schema = Class.new(GraphQL::Schema) do
1919
include ApolloFederation::Schema
2020
federation version: '2.0'
@@ -23,7 +23,7 @@
2323
expect(schema.federation_version).to eq('2.0')
2424
end
2525

26-
it 'returns the specified version when set' do
26+
it 'returns the specified version when set to 2.3' do
2727
schema = Class.new(GraphQL::Schema) do
2828
include ApolloFederation::Schema
2929
federation version: '2.3'
@@ -88,7 +88,7 @@
8888
expect(schema.federation_2?).to be(true)
8989
end
9090

91-
it 'returns true when the version is a string greater than 2.0' do
91+
it 'returns true when the version is a string equal to 2.3' do
9292
schema = Class.new(GraphQL::Schema) do
9393
include ApolloFederation::Schema
9494
federation version: '2.3'

0 commit comments

Comments
 (0)