Fix a crash when opening the debug menu with a corrupted savegame

Author: bassdr

soh/soh/Enhancements/debugger/debugSaveEditor.cpp

@@ -529,10 +529,10 @@ void DrawInventoryTab() {
         "Restrict to valid items", &restrictToValid,
         checkboxOptionsBase.Tooltip("Restricts items and ammo to only what is possible to legally acquire in-game"));
 
-    for (int32_t y = 0; y < 4; y++) {
-        for (int32_t x = 0; x < 6; x++) {
-            int32_t index = x + y * 6;
-            static int32_t selectedIndex = -1;
+    for (uint32_t y = 0; y < 4; y++) {
+        for (uint32_t x = 0; x < 6; x++) {
+            uint32_t index = x + y * 6;
+            static uint32_t selectedIndex = UINT32_MAX;
             static const char* itemPopupPicker = "itemPopupPicker";
 
             ImGui::PushID(index);
@@ -541,7 +541,8 @@ void DrawInventoryTab() {
                 ImGui::SameLine();
             }
 
-            uint8_t item = gSaveContext.inventory.items[index];
+            static_assert(sizeof(gSaveContext.inventory.items) / sizeof(gSaveContext.inventory.items[0] == 24));
+            ItemID item = index < 24 ? (ItemID)gSaveContext.inventory.items[index] : ITEM_NONE;
             PushStyleButton(Colors::DarkGray);
             if (item == ITEM_ROCS_FEATHER) {
                 auto ret = ImGui::ImageButton(
@@ -553,8 +554,8 @@ void DrawInventoryTab() {
                     selectedIndex = index;
                     ImGui::OpenPopup(itemPopupPicker);
                 }
-            } else if (item != ITEM_NONE) {
-                const ItemMapEntry& slotEntry = itemMapping.find(item)->second;
+            } else if (auto mappedItem = itemMapping.find(item); item != ITEM_NONE && mappedItem != itemMapping.end()) {
+                const ItemMapEntry& slotEntry = mappedItem->second;
                 auto ret = ImGui::ImageButton(
                     slotEntry.name.c_str(),
                     std::dynamic_pointer_cast<Fast::Fast3dGui>(Ship::Context::GetRawInstance()->GetWindow()->GetGui())