Skip to content

[hl] restore unsafe cast optimization on Map.get #12396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 4, 2025
Merged

[hl] restore unsafe cast optimization on Map.get #12396

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0cff93a
[hl] restore unsafe cast optimization on Map.get
yuxiaomao Oct 30, 2025
5bf4fae
Merge branch 'development' into dev-restore-map-get-opt
yuxiaomao Nov 3, 2025
e84ebc9
Merge branch 'development' into dev-restore-map-get-opt
yuxiaomao Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion src/generators/genhl.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2328,8 +2328,22 @@ and eval_expr ctx e =
);
(match !def_ret with
| None ->
let is_map_get_method t =
match follow t with
| TFun (_,rt) ->
(match follow rt with
| TInst({ cl_kind = KTypeParameter ttp; cl_path=["haxe";"ds";("StringMap"|"ObjectMap"|"IntMap"|"Int64Map")],_ }, _) -> true
| _ -> false)
| _ ->
false
in
let rt = to_type ctx e.etype in
cast_to ~force:true ctx ret rt e.epos
(match ec.eexpr with
| TField (_, FInstance(_,_,{ cf_kind = Method (MethNormal|MethInline); cf_type = t })) when is_map_get_method t ->
(* let's trust the compiler on map.get type *)
unsafe_cast_to ctx ret rt e.epos
| _ ->
cast_to ~force:true ctx ret rt e.epos)
| Some r -> r
)
| TField (ec,FInstance({ cl_path = [],"Array" },[t],{ cf_name = "length" })) when to_type ctx t = HDyn ->
Expand Down