test: lua: check that extension are correctly probed

The test included in this commit checks that lua will correctly probe
extension scripts, but without ensuring that it correctly follows the
data home. It only check that lua creates the correct access to load
the files.

In particular, the test fails to pass if the condition for loading .vle
files is not correct.

Author: alexandre-janniaux

test/Makefile.am

@@ -38,6 +38,7 @@ check_PROGRAMS = \
 	test_src_misc_image \
 	test_src_video_output \
 	test_src_video_output_opengl \
+	test_modules_lua_extension \
 	test_modules_misc_medialibrary \
 	test_modules_packetizer_helpers \
 	test_modules_packetizer_hxxx \
@@ -149,6 +150,10 @@ test_src_interface_dialog_LDADD = $(LIBVLCCORE) $(LIBVLC)
 test_src_media_source_LDADD = $(LIBVLCCORE) $(LIBVLC)
 test_src_media_source_SOURCES = src/media_source/media_source.c
 
+test_modules_lua_extension_SOURCES = modules/lua/extension.c
+test_modules_lua_extension_LDADD = $(LIBVLCCORE) $(LIBVLC)
+test_modules_lua_extension_CPPFLAGS = $(AM_CPPFLAGS) \
+	-DLUA_EXTENSION_DIR=\"$(srcdir)/modules/\"
 test_modules_misc_medialibrary_SOURCES = modules/misc/medialibrary.c
 test_modules_misc_medialibrary_LDADD = $(LIBVLCCORE) $(LIBVLC)
 test_modules_packetizer_helpers_SOURCES = modules/packetizer/helpers.c

test/modules/lua/extension.c

@@ -0,0 +1,106 @@
+/*****************************************************************************
+ * extension.c: test for the lua extension module
+ *****************************************************************************
+ * Copyright (C) 2023 Videolabs
+ *
+ * Authors: Alexandre Janniaux <[email protected]>
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU Lesser General Public License as published
+ * by the Free Software Foundation; either version 2.1 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public License
+ * along with this program; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin Street, Fifth Floor, Boston MA 02110-1301, USA.
+ *****************************************************************************/
+
+#ifdef HAVE_CONFIG_H
+# include <config.h>
+#endif
+
+/* Define a builtin module for mocked parts */
+#define MODULE_NAME test_lua_extension
+#define MODULE_STRING "test_lua_extension"
+#undef __PLUGIN__
+const char vlc_module_name[] = MODULE_STRING;
+
+#include "../../libvlc/test.h"
+
+#include <vlc/vlc.h>
+
+#include <vlc_common.h>
+#include <vlc_plugin.h>
+#include <vlc_modules.h>
+#include <vlc_extensions.h>
+
+#include <limits.h>
+
+static int exitcode = 0;
+
+static int OpenIntf(vlc_object_t *root)
+{
+    extensions_manager_t *mgr =
+        vlc_object_create(root, sizeof *mgr);
+    assert(mgr);
+
+    setenv("XDG_DATA_HOME", LUA_EXTENSION_DIR, 1);
+    setenv("VLC_DATA_PATH", LUA_EXTENSION_DIR, 1);
+    setenv("VLC_LIB_PATH", LUA_EXTENSION_DIR, 1);
+
+    mgr->p_module = module_need(mgr, "extension", "lua", true);
+
+    if (mgr->p_module == NULL)
+    {
+        exitcode = 77;
+        goto end;
+    }
+
+    /* Check that the extension from the test is correctly probed. */
+    assert(mgr->extensions.i_size == 1);
+    extension_Activate(mgr, mgr->extensions.p_elems[0]);
+    extension_Deactivate(mgr, mgr->extensions.p_elems[0]);
+
+    module_unneed(mgr, mgr->p_module);
+end:
+    vlc_object_delete(mgr);
+    return VLC_SUCCESS;
+}
+
+/** Inject the mocked modules as a static plugin: **/
+vlc_module_begin()
+    set_callback(OpenIntf)
+    set_capability("interface", 0)
+vlc_module_end()
+
+/* Helper typedef for vlc_static_modules */
+typedef int (*vlc_plugin_cb)(vlc_set_cb, void*);
+
+VLC_EXPORT const vlc_plugin_cb vlc_static_modules[] = {
+    VLC_SYMBOL(vlc_entry),
+    NULL
+};
+
+
+int main()
+{
+    test_init();
+
+    const char * const args[] = {
+        "-vvv", "--vout=dummy", "--aout=dummy", "--text-renderer=dummy",
+        "--no-auto-preparse",
+    };
+
+    libvlc_instance_t *vlc = libvlc_new(ARRAY_SIZE(args), args);
+
+    libvlc_add_intf(vlc, MODULE_STRING);
+    libvlc_playlist_play(vlc);
+
+    libvlc_release(vlc);
+    return 0;
+}

test/modules/lua/extensions/extensions.lua

@@ -0,0 +1,38 @@
+function descriptor()
+  return {
+    title = "test",
+    version = "0.0.1",
+    author = "VideoLAN",
+    shortdesc = "Test example",
+    description = "Test description",
+    capabilities = {
+        "input-listener",
+        "meta-listener",
+        "playing-listener",
+     }
+  }
+end
+
+function activate()
+  vlc.msg.dbg("Activate")
+end
+
+function close()
+  vlc.msg.dbg("Close")
+end
+
+function deactivate()
+  vlc.msg.dbg("Deactivate")
+end
+
+function input_changed()
+  vlc.msg.dbg("Input changed")
+end
+
+function playing_changed()
+  vlc.msg.dbg("Playing changed")
+end
+
+function meta_changed()
+  vlc.msg.dbg("Meta changed")
+end