Skip to content

Commit cd76326

Browse files
authored
Fix MacOS Pipeline: Include tests not in subdirectories (#797)
* Fix glob expansion by adding quotes and add diagnostics * Remove workaround no longer needed with Gymnasium * Bugfix in sys.modules restore * Try avoiding echo to prevent one big test filename
1 parent 4e429ce commit cd76326

File tree

4 files changed

+5
-6
lines changed

4 files changed

+5
-6
lines changed

.circleci/config.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -358,7 +358,10 @@ jobs:
358358
name: run tests
359359
command: |
360360
source ~/venv/bin/activate
361-
TESTFILES=$(circleci tests glob tests/**/test*.py | circleci tests split --split-by=timings)
361+
ALL_TESTFILES=$(circleci tests glob "tests/**/test*.py")
362+
echo "All testfiles: ${ALL_TESTFILES}"
363+
TESTFILES=$(circleci tests glob "tests/**/test*.py" | circleci tests split --split-by=timings)
364+
echo "This shard testing: ${TESTFILES}"
362365
pytest -n auto --junitxml=/tmp/test-reports/junit.xml -vv $TESTFILES
363366
364367
- save-pytest-cache

docs/requirements.txt

Lines changed: 0 additions & 2 deletions
This file was deleted.

readthedocs.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,6 @@ build:
1212

1313
python:
1414
install:
15-
# TODO(GH#707): remove docs/requirements.txt once Gym upgraded
16-
- requirements: docs/requirements.txt
1715
- method: pip
1816
path: .
1917
extra_requirements:

tests/util/test_wb_logger.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,4 +122,4 @@ def test_wandb_module_import_error():
122122
with pytest.raises(ModuleNotFoundError, match=r"Trying to log data.*"):
123123
logger.configure(format_strs=["wandb"])
124124
finally:
125-
sys.modules[wandb] = wandb_module
125+
sys.modules["wandb"] = wandb_module

0 commit comments

Comments
 (0)