Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests failing with older versions of timm #474

Closed
daniszw opened this issue Mar 5, 2025 · 3 comments · Fixed by #477
Closed

Tests failing with older versions of timm #474

daniszw opened this issue Mar 5, 2025 · 3 comments · Fixed by #477
Assignees
Labels
0.99.9 bug Something isn't working

Comments

@daniszw
Copy link
Collaborator

daniszw commented Mar 5, 2025

Some tests are failing with the error:

AttributeError: 'ResNet' object has no attribute 'forward_intermediates'

if using older versions of timm (0.9.7 fails while 1.0.15 works, for example) but no versions of timm are specified on pyproject.toml file.

@Joao-L-S-Almeida Joao-L-S-Almeida self-assigned this Mar 5, 2025
@Joao-L-S-Almeida
Copy link
Member

Joao-L-S-Almeida commented Mar 5, 2025

We have tried to install the latest versions of the dependencies as much as possible and that has worked.
Do you think we should define a lower bound for them ?

@daniszw
Copy link
Collaborator Author

daniszw commented Mar 5, 2025

In my opinion, if the error is directly related to having some older but, in theory, allowed versions installed, the version requirements should be specified in the toml file. The errors are coming from here:

features = self.resnet_model.forward_intermediates(x, intermediates_only=True)

This is a piece of terratorch code calling directly some timm functionality, which apparently doesn't exist for older versions. Therefore, in my opinion, this should be clear in the toml file.

@Joao-L-S-Almeida
Copy link
Member

I think the best we can do for now is really limiting for timm>=1.0.15, since this has been used in the automatic tests and has worked.

@Joao-L-S-Almeida Joao-L-S-Almeida linked a pull request Mar 6, 2025 that will close this issue
@Joao-L-S-Almeida Joao-L-S-Almeida added 0.99.9 bug Something isn't working labels Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.99.9 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants