Skip to content

Commit 885f317

Browse files
committed
fix(dref-translation): update finalize access logic and status descriptions
1 parent ef60160 commit 885f317

File tree

3 files changed

+21
-4
lines changed

3 files changed

+21
-4
lines changed

app/src/views/AccountMyFormsDref/ActiveDrefTable/i18n.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,9 @@
1010
"activeDrefTableCountryHeading": "Country",
1111
"activeDrefTableStatusHeading": "Status",
1212
"activeDrefTableStatusDraftDescription": "The form is in its initial stage and has not been finalized yet.",
13-
"activeDrefTableStatusFinalizingDescription": "The form is being finalizing. The original language content is being translated into English.",
13+
"activeDrefTableStatusFinalizingDescription": "The form is being finalizing. The fields are being translated into English.",
1414
"activeDrefTableStatusFinalizedDescription": "The form has been finalized, and the original language has been switched to English. All further edits must now be made in English.",
15-
"activeDrefTableStatusApprovedDescription": "Approved: The form has been reviewed and approved.",
15+
"activeDrefTableStatusApprovedDescription": "The form has been reviewed and approved.",
1616
"activeDrefTableStatusFailedDescription": "The form finalization process has failed. You can retry to finalize the form again"
1717
}
1818
}

app/src/views/AccountMyFormsDref/DrefTableActions/index.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -564,8 +564,8 @@ function DrefTableActions(props: Props) {
564564

565565
const canApprove = status === DREF_STATUS_FINALIZED && hasPermissionToApprove;
566566

567-
const canFinalize = status === (DREF_STATUS_DRAFT
568-
|| DREF_STATUS_FAILED)
567+
const canFinalize = (status === DREF_STATUS_DRAFT
568+
|| status === DREF_STATUS_FAILED)
569569
&& hasPermissionToApprove;
570570

571571
const shouldConfirmImminentAddOpsUpdate = drefType === DREF_TYPE_IMMINENT && isDrefImminentV2;
Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
{
2+
"parent": "000054-1762426529619.json",
3+
"actions": [
4+
{
5+
"action": "update",
6+
"key": "activeDrefTableStatusApprovedDescription",
7+
"namespace": "accountMyFormsDref",
8+
"newValue": "The form has been reviewed and approved."
9+
},
10+
{
11+
"action": "update",
12+
"key": "activeDrefTableStatusFinalizingDescription",
13+
"namespace": "accountMyFormsDref",
14+
"newValue": "The form is being finalizing. The fields are being translated into English."
15+
}
16+
]
17+
}

0 commit comments

Comments
 (0)