Merge pull request #87 from INN/86-category-tags-targeting

Fix targeting for categories and tags when wp_footer is outside The Loop

Author: benlk

dfw-init.php

@@ -216,6 +216,7 @@ public function footer_script() {
 	}
 
 	private function targeting() {
+		global $wp_query;
 		/** @see http://codex.wordpress.org/Conditional_Tags */
 
 		$targeting = array();
@@ -263,7 +264,12 @@ private function targeting() {
 		}
 
 		if ( is_singular() && ( ! is_post_type_archive() && ! is_front_page() ) ) {
-			$cats = get_the_category();
+			// https://wordpress.org/support/topic/categories-tags-bug-and-solution/
+			$cat_post_id = $wp_query->get_queried_object_id();
+			if ( 0 === $cat_post_id ) {
+				$cat_post_id = null; // get_queried_object_id returns 0 for no post found; get_the_category expects null;
+			}
+			$cats = get_the_category( $cat_post_id );
 			$targeting['Category'] = array();
 
 			if ( ! empty( $cats ) ) {
@@ -281,8 +287,13 @@ private function targeting() {
 			$targeting['Category'][] = $queried_object->slug;
 		}
 
-		if ( is_single() ) {
-			$tags = get_the_tags();
+		if ( is_singular() && ( ! is_post_type_archive() && ! is_front_page() ) ) {
+			// https://wordpress.org/support/topic/categories-tags-bug-and-solution/
+			$tag_post_id = $wp_query->get_queried_object_id();
+			if ( 0 === $tag_post_id ) {
+				$tag_post_id = null; // get_queried_object_id returns 0 for no post found; get_the_tags expects null;
+			}
+			$tags = get_the_tags( $tag_post_id );
 			if ( $tags ) {
 				$targeting['Tag'] = array();
 				foreach ( $tags as $t ) {

readme.txt

@@ -33,12 +33,15 @@ For more advanced documentation for developers and advanced users see [the offic
 
 = 0.3 =
 
+Thanks to WordPress.org user [onlineforbusiness](https://wordpress.org/support/users/onlineforbusiness/) and GitHub user [dbeniaminov](https://github.com/dbeniaminov) for their contributions to this release.
+
 - Rebrands from "DoubleClick for WordPress" to "Super Cool Ad Manager Plugin", because [Google merged DoubleClick for Publishers into Google Ad Manager](https://www.blog.google/products/admanager/introducing-google-ad-manager/).
 - Updates to `jquery.dfp.js` version 2.4.2, adding `setCentering` support. [PR #67](https://github.com/INN/doubleclick-for-wp/pull/67) for [issue #66](https://github.com/INN/doubleclick-for-wp/issues/66)
 - Removes 'single' page targeting from post-type archives and from static front pages. [PR #72](https://github.com/INN/doubleclick-for-wp/pull/72) for [issue #61](https://github.com/INN/doubleclick-for-wp/issues/61), thanks to GitHub user [dbeniaminov](https://github.com/dbeniaminov).
 - Adds "Category" targeting on category archive. [PR #72](https://github.com/INN/doubleclick-for-wp/pull/72) for [issue #61](https://github.com/INN/doubleclick-for-wp/issues/61).
 - Adds "Tag" targeting on tag archive. [PR #74](https://github.com/INN/doubleclick-for-wp/pull/74) for [issue #29](https://github.com/INN/doubleclick-for-wp/issues/29).
 - Fixes a number of PHP warnings and errors, including [issue #8](https://github.com/INN/doubleclick-for-wp/issues/8) and [issue #37](https://github.com/INN/doubleclick-for-wp/issues/37) in [PR #76](https://github.com/INN/doubleclick-for-wp/pull/76) and [issue #31](https://github.com/INN/doubleclick-for-wp/issues/31) in [PR #80](https://github.com/INN/doubleclick-for-wp/pull/80/).
+- Fixes a targeting problem that occurred when wp_footer ran outside The Loop. ([PR #87](https://github.com/INN/doubleclick-for-wp/pull/87) for [this support topic](https://wordpress.org/support/topic/categories-tags-bug-and-solution/).)
 - Adds "Ad unit" label to widget settings for the "Identifier" setting, to match Google's language. [PR #73](https://github.com/INN/doubleclick-for-wp/pull/73) for [issue #26](https://github.com/INN/doubleclick-for-wp/issues/26).
 - Adds GitHub Pull Request template and Contributing guidelines files.
 - Adds a plugin text domain: `dfw`. ([PR #76](https://github.com/INN/doubleclick-for-wp/pull/76))