cleanup

Author: pcrespov

.github/PULL_REQUEST_TEMPLATE.md

@@ -10,6 +10,7 @@
   ⬆️    Upgrade dependencies.
   📝    Add or update documentation.
   🔨    Add or update development scripts.
+  ✅    Add, update or pass tests.
   🔒️    Fix security issues.
   ⚠️    Changes in ops configuration etc. are required before deploying.
         [ Please add a link to the associated ops-issue or PR, such as in https://github.com/ITISFoundation/osparc-ops-environments or https://git.speag.com/oSparc/osparc-infra ]
@@ -28,13 +29,7 @@ or from https://gitmoji.dev/
 
 
 ## Related issue/s
-
-<!-- Link pull request to an issue
-  SEE https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue
-
-- resolves ITISFoundation/osparc-issues#428
-- fixes #26
--->
+<!-- LINK to other issues and add prefix `closes`, `fixes`, `resolves`-->
 
 
 ## How to test
@@ -43,17 +38,6 @@ or from https://gitmoji.dev/
 
 ## Dev-ops checklist
 
-- [ ] No ENV changes or I properly updated ENV ([read the instruction](https://git.speag.com/oSparc/osparc-ops-deployment-configuration/-/blob/configs/README.md?ref_type=heads#how-to-update-env-variables))
+- [ ] No ENV changes or I properly updated ENV (i.e. repo.config)
 
-<!-- Some checks that might help your code run stable on production, and help devops assess criticality.
-Modified from https://oschvr.com/posts/what-id-like-as-sre/
-
-- How can DevOps check the health of the service ?
-- How can DevOps safely and gracefully restart the service ?
-- How and why would this code fail ?
-- What kind of metrics are you exposing ?
-- Is there any documentation/design specification for the service ?
-- How (e.g. through which loglines) can DevOps detect unexpected situations that require escalation to human ?
-- What are the resource limitations (CPU, RAM) expected for this service ?
-- Are all relevant variables documented and adjustable via environment variables (i.e. no hardcoded magic numbers) ?
--->
+<!-- Details in  docs/devops-checklist.md -->

docs/devops-checklist.md

@@ -0,0 +1,15 @@
+# Devops checklist
+
+- No ENV changes or I properly updated ENV ([read the instruction](https://git.speag.com/oSparc/osparc-ops-deployment-configuration/-/blob/configs/README.md?ref_type=heads#how-to-update-env-variables))
+
+- Some checks that might help your code run stable on production, and help devops assess criticality.
+  - How can DevOps check the health of the service ?
+  - How can DevOps safely and gracefully restart the service ?
+  - How and why would this code fail ?
+  - What kind of metrics are you exposing ?
+  - Is there any documentation/design specification for the service ?
+  - How (e.g. through which loglines) can DevOps detect unexpected situations that require escalation to human ?
+  - What are the resource limitations (CPU, RAM) expected for this service ?
+  - Are all relevant variables documented and adjustable via environment variables (i.e. no hardcoded magic numbers) ?
+
+Ref: Modified from https://oschvr.com/posts/what-id-like-as-sre/