Skip to content

Validate webhooks in ContactForm #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
raviks789 opened this issue Jun 18, 2024 · 2 comments
Closed

Validate webhooks in ContactForm #210

raviks789 opened this issue Jun 18, 2024 · 2 comments

Comments

@raviks789
Copy link
Contributor

raviks789 commented Jun 18, 2024 •
edited
Loading

I am not completely sure, but IMO we need to add a validator to validate the webhook URLs.
@raviks789 raviks789 assigned raviks789 and unassigned raviks789 Jun 19, 2024
@oxzi oxzi mentioned this issue Jun 27, 2024
Merged
@nilmerg
Copy link
Member

nilmerg commented Jan 21, 2025

To validate what? If it's reachable? If it returns a specific response code? Difficult, in my understanding, since it might only succeed with a valid request body, which we cannot really fake.

@nilmerg
Copy link
Member

nilmerg commented Jan 21, 2025

Related to #257 and closing due to this.

@nilmerg nilmerg closed this as not planned Won't fix, can't repro, duplicate, stale Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nilmerg @raviks789