Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deactivating Host Service from Service Set doesn't create Activity Log entry due to missing Hash Change #2911

Open
Wintermute2k6 opened this issue Aug 26, 2024 · 2 comments · May be fixed by #2915
Open

Deactivating Host Service from Service Set doesn't create Activity Log entry due to missing Hash Change #2911

Wintermute2k6 opened this issue Aug 26, 2024 · 2 comments · May be fixed by #2915
Assignees
@raviks789
Labels
bug ref/NC
Milestone
v1.11.2

Comments

@Wintermute2k6
Copy link

Expected Behavior

Most host/service changes in the director module create viewable traceable/change in the activity log.
This is for debugging reasons great also for debugging.

Current Behavior

Creating a Service => hash change in Activity log
Creating a Service Set => hash chnage in Activity log
Deactivating service on host from service sest => no trace from that action in the activity log

Possible Solution

creating a hash for the 'deactivating' and create an traceable entry in the activity log ?

Steps to Reproduce (for bugs)

  • fresh icinga2 & icingaweb2 or icingadb and icingadb-web install and latest director module.
  • create testhost
  • create service set + testservice
  • apply service set to testhost
  • view for the three steps before the activity log entries
  • deactivate service on testhost
  • no activity log entry created

Your Environment

  • Director version (System - About):
    Icinga Web 2 Version | 2.12.1
    cd2daeb2cb8537c633d343a29eb76c54cd2ebbf2
    7.4.3-4ubuntu2.23
    2023-11-15
    Icinga Web 2 Version 2.12.1
    Git commit cd2daeb2cb8537c633d343a29eb76c54cd2ebbf2
    PHP Version 7.4.3-4ubuntu2.23
    Git commit date 2023-11-15
    Loaded Libraries
    icinga/icinga-php-library 0.14.1
    icinga/icinga-php-thirdparty 0.12.1
    Loaded Modules
    director 1.11.1
    incubator 0.22.0
    monitoring 2.12.1
@Wintermute2k6
Copy link
Author

ref/NC/827341

@raviks789 raviks789 added bug and removed enhancement labels Sep 10, 2024
@raviks789
Copy link
Collaborator

raviks789 commented Sep 10, 2024 •
edited
Loading

To be clear on why this is an issue. Here is how the logging of services currently works.

  1. When you delete a single service directly attached to an host, or an applied service or a service in a service set. The activity is logged as it should.
  2. But when you particularly navigate to a host and deactivate a service that is inherited from an host template or applied through a service apply rule or a service under a service set the activity is not logged.

Why is it a problem to not log deactivating a service in a specific host?

It is difficult to know in which hosts the said service is deactivated. Even for small number of hosts it would be cumbersome to navigate to individual hosts and check whether that service is deactivated.

So, it would be necessary to also log when a service is deactivated in a specific host for it to be traceable.

@raviks789 raviks789 added this to the v1.11.2 milestone Sep 10, 2024
@raviks789 raviks789 linked a pull request Sep 13, 2024 that will close this issue
Draft
@raviks789 raviks789 self-assigned this Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raviks789 raviks789

Labels
bug ref/NC
Projects
None yet
Milestone
v1.11.2
Development

Successfully merging a pull request may close this issue.

Log activation or deactivation of services applied to hosts Icinga/icingaweb2-module-director
2 participants
@Wintermute2k6 @raviks789