docs: added warning for Databricks integration #3219
Conversation
WalkthroughThe documentation for the Databricks integration has been updated to include a warning message. This message informs users that applying the integration will delete all existing secrets in Databricks, and it advises them to back up their secrets beforehand. The documentation also clarifies that this deletion behavior is a known limitation and indicates that it will be addressed in a future update. No changes were made to the declarations of exported or public entities. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/integrations/cloud/databricks.mdx (1)
6-8: Fix Typo in Warning MessageThere's a minor typo in the warning message ("integeration" should be "integration"). Correcting this will ensure clarity and professionalism in the documentation.
Apply the following diff:
-Databricks integeration will delete all your existing secrets. Make sure to back them up before starting the integration. This is a known limitation and will be fixed in the future. +Databricks integration will delete all your existing secrets. Make sure to back them up before starting the integration. This is a known limitation and will be fixed in the future.
|
Hey @vikramnagwal, thanks for opening this PR and this concern to our attention. The behavior you've pointed out is not unique to Databricks; Infisical integrations are intended to act as the source of truth for the destination and at the moment we don't recommend trying to manually manage secrets outside of Infisical with an integration. With the Native Integration you can avoid this behavior by creating a designated scope for Infisical secrets in Databricks; that way secrets in other Databricks scopes will not be affected. We'll add this to the docs to help clarify this behavior as you suggested. We've also made this behavior more clear with our new Secret Syncs (think integrations v2) which we do have a Databricks release for. In addition, we do intend to release the ability to disable deletion of secrets in the coming weeks for Secret Syncs which will address that concern. |
|
closing as resolved by #3225 |
|
@scott-ray-wilson, I was unaware of that. Please excuse me. |
|
@vikramnagwal just wanted to notify you we've released the ability to disable secret deletion for our Databricks Secret Sync as an alternative to creating a unique secret scope for Infisical. |
Resolves: #3173
Description 📣
This PR will add a prominent warning to the Databricks integration documentation page so users can avoid losing their important secrets. This warning will inform them until the bug is fixed.
Type ✨
Tests 🛠️
Summary by CodeRabbit