-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check videos against workbook after creation #122
Comments
We can also do this check after creating the video scripts yet still before shooting the video itself (#140) |
Screenlight link available here: https://innersourcecommons.slack.com/archives/CARTU4XV2/p1573840051113600 |
At this point the ask is to
|
@BrittanyIstenes working on this. |
Intro Review - Complete Introduction - Video 3
Introduction - Video 4
Introduction - Video 5
|
Here is the workbook: https://github.com/InnerSourceCommons/InnerSourceLearningPath/tree/master/workbook Try out the assessment questions (no peeking). |
Do we control said URL such that we could un-404 it? |
Which URL, specifically, are we talking about? |
Is that URL embedded into the video? In that case fixing it would be quite a bit more of an effort. |
It is in our repos. Opened #251 to fix. |
Introduction and Product Owner complete. Product Owner question "Roles and Responsibilities" was a tricky one. The content in the video was super deep, and the wording didnt quite align from the video to the way that the question was phrased within the answer choices. I mean, it did force me to rewatch the video to check the answer reasoning, but it was a hard one. |
Good call out. |
Some more feedback coming soon from Brittany |
Trusted Committer videos were solid and Workbook followed suit. |
Great to hear! Nice work, everyone! 🙌 |
Added a bunch of check boxes in the original ticket to track the state. Checked boxes according to what I've read here. Feel free to do some checkbox ticking as you see fit @BrittanyIstenes and thanks for reviewing! 😃 |
Good point about the boxes. Great way to track what's been done! |
Team, to be honest, the question albeit confusing for me is probably not that way for many. I personally think just leave it. I do not have the best mind for creating in-depth questions like this one. |
@mtabbal interested in looking at Contributor videos vs. workbook questions. |
@Ludmila-N might be interested in doing the review for the last few videos and @lenucksi can put up the YT links to the videos next to the items. |
Reviewing Contributor videos, so far the first two, I see a couple glitches with https://innersourcecommons.org/learn/learning-path/contributor/02/
What are the ways we can address both/either of these? |
Thanks for reviewing!
The intent here is "bug tickets" "well written issues". At least the good ones already help tremendously, so I definitely would want them. Where "well written" means: Detailed, with reproduction step, expectations and reality, possibly even a first patch or guess at a code location. Maybe we could add a small overlay on the video?
Added a suggestion for the first. For the second one I think the intent of the question is in the correct answer and its explanation. Could we maybe replace or enhance the question so it fits the video and intent? |
Understood, and you say this in a few seconds - so this was provably a self-correction, but it sounds like you're listing bugs along with bug tickets. I think the best option is to cut or mute these ~5 seconds and leave the rest as is. |
Reviewing Contributor videos, Contributor Ethos section:
Also "fulfill" is spelled with double L at the end. |
Cutting it out sounds good. Do you happen to have taken a note of the time-code such that I can just edit it out and re-upload it? |
"Providing good bugs" is at 3:25, "providing good issue tickets for bugs" is at 3:29 |
The modified video is now on Youtube https://youtu.be/S0Gps2AbZ7M courtesy of @Katiegilroyy Can I just change the website directly to point it to the video or do you have to do it in your repository? |
New video is live and adapted. Remaining is adaptation of the Workbook question |
Nice work! |
I've watched the Introduction videos and I was able to complete their corresponding workbook. I'm totally uninvolved in their creation, but on the other hand I already have some previous knowledge about open source communities, so take my feedback with a pinch of salt. |
Thanks for this review @fioddor. |
@lenucksi can you update the checkboxes in the description with what has been done and what is left? |
What we have left:
Rationale
The workbook contains questions based on the videos - one could consider this the take-aways.
Especially in the case of the Contributor we are creating workbook content before the videos based on the Outline and the articles.
We need to ensure that the videos and articles contain content that matches the workbook questions and makes them properly answerable.
Action items & acceptance criteria
Prior to making the videos
After making the videos
Acceptance:
The text was updated successfully, but these errors were encountered: