Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation of the book to Spanish #785

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

ovas04
Copy link

@ovas04 ovas04 commented Mar 7, 2025

Add Spanish translations for:

  • Book
  • Patterns Categorization
  • Patterns

Modify the workflow to include Spanish language support

Copy link

welcome bot commented Mar 7, 2025

Thank You Banner

💖 Thanks for opening this pull request! 💖 The InnerSource Commons community really appreciates your time and effort to contribute to the project. Please make sure you have read our Contributing Guidelines.

If you are submitting a new pattern, the following things will help get your pull request across the finish line! 🏁

  • Confirm that you have used our pattern template. Please remove any placeholder text and sections that your pattern did not need.
  • We run a number of automated checks on your PR. Please review the output of those checks on the PR itself, and see if any issues got flagged that you can fix yourself.
  • Make sure you have added your new pattern to the list of patterns in the main README.md. If you are unsure where to add your pattern, just let us know by commenting on your PR and we will help you.

This project has a small number of maintainers, volunteering their time to this project. So please be patient and we will get back to you as soon as we can. If we don't acknowledge this pull request after 7 days, feel free to chat to us about it in our Slack workspace.

@spier spier linked an issue Mar 7, 2025 that may be closed by this pull request
… the toc generation. Also regenerate the toc for Spanish.
@spier
Copy link
Member

spier commented Mar 7, 2025

@ovas04 I put up a preview of your Spanish content on our staging site. There you can check how it looks like in our hosting platform (we use gitbook): https://innersourcecommons.gitbook.io/innersource-patterns-staging/es-test

FYI I had to copy your branch into our repo, so that I could generate this preview. If you want to make changes, you can make them to your own branch though (this PR here).

Besides that I will try to find somebody who can do a review of the content in Spanish (as I don't speak that language). Or do you have somebody that would be interested and willing to review your Spanish translations?

@spier spier added the Type - Translation Translating patterns into other languages label Mar 7, 2025
@spier spier requested a review from psanxiao as a code owner March 7, 2025 07:12
Copy link
Member

@spier spier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a technical perspective your PR looks great already @ovas04! At least from the quick check that I did, the content seems to render correctly in our preview site. 🥳

Now let's wait and see if we can get some other Spanish speakers in the community to give this a review, so that we have at least a 2nd pair of eyes on it :)

Besides that, I added you as a translation lead for the Spanish translation. This just means that you would get an alert if anybody proposes a change/fix to the translation after it goes live. Would that work for you?

If you like, we can also translate the cover image of the book. Just let me know which text I should use for title and subtitle. I have the originals for that cover image somewhere, and can create the Spanish version for.

@spier
Copy link
Member

spier commented Mar 9, 2025

@ovas04 and @rmarting thank you for your great work on this.

You can just let me know when you feel this translation is good enough to be released. Does not have to be perfect! At least in my mind, having "a translation" is already a lot better than what we have now (which is none haha). I am assuming that at least for part of the Spanish speaking community it will be a lot easier to consume this material in their native language.

So you just tell me when we are good to go. Then I will do the remaining administrative work to get the Spanish translation released on our production site.

And of course, we can always fix other glitches in an iterative fashion after this, if we like.

PS: I will be at a conference for a couple of days now, and might not be a all that responsive.

@rmarting
Copy link
Contributor

I would like to take a few days more to complete the review. In general, looks great, just to complete the reading and highlight the most important things. Does it work for you before releasing the whole new Spanish site?


Un proyecto debe establecer las siguientes herramientas de comunicación:

1. **Gestor de tareas dedicado** donde la comunicación estructurada, la toma de decisiones y el seguimiento del progreso pueden ocurrir de manera transparente para todos los miembros del equipo anfitrión y también para los usuarios y contribuyentes posteriores. Para más aplicaciones del gestor de problemas, ver [Casos de Uso del Gestor de Problemas](./issue-tracker.md).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patern name: Casos de uso del Gestor de Tareas

Copy link
Contributor

@rmarting rmarting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TL;DR: LGTM

The content is good enough and there is always space for improvement, but the content is live and the changes should be minimal (as Spanish native speaker some sentences could be changed, but it is fine). I reviewed the whole content from the PR layout, and I would like to take a look of the testing site including the whole content (and reviews done) before publishing online. Then I can confirm and approve everything.

I would like to congratulate @ovas04 for his amazing job and flexiblity to adapt my comments. I know that he is the main contributor, just wondering if I could be part of the footer to support in the future any new translation. Suggesting from the ignorance about the rules to add names in the translated pages.

- **2025-04-03** - Traducción [Roman Martin Gil](https://github.com/rmarting)

PS: Just reported the #788 to satisfy the workflows. Not sure if it is a blocker to promote the content.

@ovas04
Copy link
Author

ovas04 commented Mar 11, 2025

TL;DR: LGTM

The content is good enough and there is always space for improvement, but the content is live and the changes should be minimal (as Spanish native speaker some sentences could be changed, but it is fine). I reviewed the whole content from the PR layout, and I would like to take a look of the testing site including the whole content (and reviews done) before publishing online. Then I can confirm and approve everything.

I would like to congratulate @ovas04 for his amazing job and flexiblity to adapt my comments. I know that he is the main contributor, just wondering if I could be part of the footer to support in the future any new translation. Suggesting from the ignorance about the rules to add names in the translated pages.

- **2025-04-03** - Traducción [Roman Martin Gil](https://github.com/rmarting)

PS: Just reported the #788 to satisfy the workflows. Not sure if it is a blocker to promote the content.

Of course, @rmarting! I was actually going to ask you about that. Give me a couple of hours, and I’ll update everything accordingly.

@spier
Copy link
Member

spier commented Mar 11, 2025

You two are amazing. It was very cool to see this smooth collaboration from the sidelines :)

I can get this PR merged by the end of the week and will then bring the Spanish translation live.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type - Translation Translating patterns into other languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Translation] Spanish Support
3 participants