Add nullptr Value check to Fill128 C-API

Author: vlad-perevezentsev

libsyclinterface/source/dpctl_sycl_queue_interface.cpp

@@ -1184,7 +1184,7 @@ DPCTLQueue_Fill128(__dpctl_keep const DPCTLSyclQueueRef QRef,
                    size_t Count)
 {
     auto Q = unwrap<queue>(QRef);
-    if (Q && USMRef) {
+    if (Q && USMRef && Value) {
         sycl::event ev;
         try {
             complexNumber Val;
@@ -1198,8 +1198,8 @@ DPCTLQueue_Fill128(__dpctl_keep const DPCTLSyclQueueRef QRef,
         return wrap<event>(new event(std::move(ev)));
     }
     else {
-        error_handler("QRef or USMRef passed to fill128 were NULL.", __FILE__,
-                      __func__, __LINE__);
+        error_handler("QRef, USMRef, or Value passed to fill128 were NULL.",
+                      __FILE__, __func__, __LINE__);
         return nullptr;
     }
 }
@@ -1213,7 +1213,7 @@ DPCTLQueue_Fill128WithEvents(__dpctl_keep const DPCTLSyclQueueRef QRef,
                              size_t DepEventsCount)
 {
     auto Q = unwrap<queue>(QRef);
-    if (Q && USMRef) {
+    if (Q && USMRef && Value) {
         sycl::event ev;
         try {
             std::vector<event> dep_events;
@@ -1236,8 +1236,9 @@ DPCTLQueue_Fill128WithEvents(__dpctl_keep const DPCTLSyclQueueRef QRef,
         return wrap<event>(new event(std::move(ev)));
     }
     else {
-        error_handler("QRef or USMRef passed to fill128_async were NULL.",
-                      __FILE__, __func__, __LINE__);
+        error_handler(
+            "QRef, USMRef, or Value passed to fill128_async were NULL.",
+            __FILE__, __func__, __LINE__);
         return nullptr;
     }
 }

libsyclinterface/tests/test_sycl_queue_interface.cpp

@@ -795,6 +795,10 @@ TEST_P(TestDPCTLQueueMemberFunctions, CheckFill128)
     ASSERT_NO_FATAL_FAILURE(p = DPCTLmalloc_device(nbytes, QRef));
     ASSERT_FALSE(p == nullptr);
 
+    ASSERT_NO_FATAL_FAILURE(
+        Fill128_ERef = DPCTLQueue_Fill128(QRef, (void *)p, nullptr, nelems));
+    ASSERT_FALSE(bool(Fill128_ERef));
+
     ASSERT_NO_FATAL_FAILURE(
         Fill128_ERef = DPCTLQueue_Fill128(
             QRef, (void *)p, reinterpret_cast<uint64_t *>(&val), nelems));
@@ -993,6 +997,10 @@ TEST_P(TestDPCTLQueueMemberFunctions, CheckFill128WithEvents)
     ASSERT_NO_FATAL_FAILURE(p = DPCTLmalloc_device(nbytes, QRef));
     ASSERT_FALSE(p == nullptr);
 
+    ASSERT_NO_FATAL_FAILURE(Fill_ERef = DPCTLQueue_Fill128WithEvents(
+                                QRef, (void *)p, nullptr, nelems, nullptr, 0));
+    ASSERT_FALSE(bool(Fill_ERef));
+
     ASSERT_NO_FATAL_FAILURE(
         FillDep_ERef = DPCTLQueue_Fill128(
             QRef, (void *)p, reinterpret_cast<uint64_t *>(&zero), nelems));