Apply remarks for c++ files

Author: vlad-perevezentsev

dpctl_ext/tensor/libtensor/include/kernels/copy_and_cast.hpp

@@ -33,25 +33,20 @@
 //===----------------------------------------------------------------------===//
 
 #pragma once
-#include <complex>
+#include <algorithm>
+#include <array>
 #include <cstddef>
 #include <cstdint>
 #include <sycl/sycl.hpp>
-#include <type_traits>
+#include <vector>
 
 #include "dpctl_tensor_types.hpp"
 #include "kernels/alignment.hpp"
 #include "utils/offset_utils.hpp"
 #include "utils/sycl_utils.hpp"
 #include "utils/type_utils.hpp"
 
-namespace dpctl
-{
-namespace tensor
-{
-namespace kernels
-{
-namespace copy_and_cast
+namespace dpctl::tensor::kernels::copy_and_cast
 {
 
 using dpctl::tensor::ssize_t;
@@ -1282,7 +1277,4 @@ struct CopyForRollNDShiftFactory
     }
 };
 
-} // namespace copy_and_cast
-} // namespace kernels
-} // namespace tensor
-} // namespace dpctl
+} // namespace dpctl::tensor::kernels::copy_and_cast

dpctl_ext/tensor/libtensor/include/kernels/copy_as_contiguous.hpp

@@ -33,25 +33,20 @@
 //===----------------------------------------------------------------------===//
 
 #pragma once
-#include <complex>
+#include <algorithm>
+#include <array>
 #include <cstddef>
 #include <cstdint>
 #include <sycl/sycl.hpp>
-#include <type_traits>
+#include <vector>
 
 #include "dpctl_tensor_types.hpp"
 #include "kernels/alignment.hpp"
 #include "utils/offset_utils.hpp"
 #include "utils/sycl_utils.hpp"
 #include "utils/type_utils.hpp"
 
-namespace dpctl
-{
-namespace tensor
-{
-namespace kernels
-{
-namespace copy_as_contig
+namespace dpctl::tensor::kernels::copy_as_contig
 {
 
 using dpctl::tensor::ssize_t;
@@ -648,8 +643,4 @@ struct AsCContigNDBatchOfSquareMatricesFactory
         return as_c_contiguous_nd_batch_of_square_matrices_impl<T>;
     }
 };
-
-} // namespace copy_as_contig
-} // namespace kernels
-} // namespace tensor
-} // namespace dpctl
+} // namespace dpctl::tensor::kernels::copy_as_contig

dpctl_ext/tensor/libtensor/source/copy_and_cast_usm_to_usm.cpp

@@ -32,38 +32,27 @@
 /// This file defines functions of dpctl.tensor._tensor_impl extensions
 //===----------------------------------------------------------------------===//
 
-#include <algorithm>
-#include <complex>
+#include <array>
 #include <cstddef>
-#include <cstdint>
-#include <stdexcept>
 #include <sycl/sycl.hpp>
-#include <thread>
-#include <type_traits>
+#include <tuple>
 #include <utility>
+#include <vector>
 
 #include "dpnp4pybind11.hpp"
-#include <pybind11/complex.h>
-#include <pybind11/numpy.h>
 #include <pybind11/pybind11.h>
-#include <pybind11/stl.h>
 
 #include "kernels/copy_and_cast.hpp"
 #include "utils/memory_overlap.hpp"
 #include "utils/offset_utils.hpp"
 #include "utils/output_validation.hpp"
 #include "utils/sycl_alloc_utils.hpp"
 #include "utils/type_dispatch.hpp"
-#include "utils/type_utils.hpp"
 
 #include "copy_as_contig.hpp"
 #include "simplify_iteration_space.hpp"
 
-namespace dpctl
-{
-namespace tensor
-{
-namespace py_internal
+namespace dpctl::tensor::py_internal
 {
 
 namespace td_ns = dpctl::tensor::type_dispatch;
@@ -305,6 +294,4 @@ void init_copy_and_cast_usm_to_usm_dispatch_tables(void)
     dtb_1d.populate_dispatch_table(copy_and_cast_1d_dispatch_table);
 }
 
-} // namespace py_internal
-} // namespace tensor
-} // namespace dpctl
+} // namespace dpctl::tensor::py_internal

dpctl_ext/tensor/libtensor/source/copy_and_cast_usm_to_usm.hpp

@@ -38,13 +38,8 @@
 #include <vector>
 
 #include "dpnp4pybind11.hpp"
-#include <pybind11/pybind11.h>
 
-namespace dpctl
-{
-namespace tensor
-{
-namespace py_internal
+namespace dpctl::tensor::py_internal
 {
 
 extern std::pair<sycl::event, sycl::event> copy_usm_ndarray_into_usm_ndarray(
@@ -55,6 +50,4 @@ extern std::pair<sycl::event, sycl::event> copy_usm_ndarray_into_usm_ndarray(
 
 extern void init_copy_and_cast_usm_to_usm_dispatch_tables();
 
-} // namespace py_internal
-} // namespace tensor
-} // namespace dpctl
+} // namespace dpctl::tensor::py_internal

dpctl_ext/tensor/libtensor/source/copy_as_contig.cpp

@@ -32,10 +32,11 @@
 /// This file defines functions of dpctl.tensor._tensor_impl extensions
 //===----------------------------------------------------------------------===//
 
-#include <algorithm>
 #include <cstddef>
+#include <iterator>
 #include <numeric>
 #include <stdexcept>
+#include <tuple>
 #include <utility>
 #include <vector>
 
@@ -54,13 +55,10 @@
 #include "copy_as_contig.hpp"
 #include "simplify_iteration_space.hpp"
 
-namespace dpctl
-{
-namespace tensor
-{
-namespace py_internal
+namespace dpctl::tensor::py_internal
 {
 
+namespace py = pybind11;
 namespace td_ns = dpctl::tensor::type_dispatch;
 
 using dpctl::tensor::kernels::copy_as_contig::
@@ -753,6 +751,4 @@ std::pair<sycl::event, sycl::event>
                           ascontig_ev);
 }
 
-} // end of namespace py_internal
-} // end of namespace tensor
-} // end of namespace dpctl
+} // namespace dpctl::tensor::py_internal

dpctl_ext/tensor/libtensor/source/copy_as_contig.hpp

@@ -32,14 +32,9 @@
 #include <vector>
 
 #include "dpnp4pybind11.hpp"
-#include <pybind11/pybind11.h>
 #include <sycl/sycl.hpp>
 
-namespace dpctl
-{
-namespace tensor
-{
-namespace py_internal
+namespace dpctl::tensor::py_internal
 {
 
 std::pair<sycl::event, sycl::event>
@@ -56,6 +51,4 @@ std::pair<sycl::event, sycl::event>
 
 void init_copy_as_contig_dispatch_vectors(void);
 
-} // end of namespace py_internal
-} // end of namespace tensor
-} // end of namespace dpctl
+} // namespace dpctl::tensor::py_internal

dpctl_ext/tensor/libtensor/source/device_support_queries.cpp

@@ -39,13 +39,11 @@
 #include <pybind11/stl.h>
 #include <sycl/sycl.hpp>
 
-namespace dpctl
-{
-namespace tensor
-{
-namespace py_internal
+namespace dpctl::tensor::py_internal
 {
 
+namespace py = pybind11;
+
 namespace
 {
 
@@ -61,7 +59,6 @@ std::string _default_device_fp_type(const sycl::device &d)
 
 int get_numpy_major_version()
 {
-    namespace py = pybind11;
 
     py::module_ numpy = py::module_::import("numpy");
     py::str version_string = numpy.attr("__version__");
@@ -179,6 +176,4 @@ std::string default_device_index_type(const py::object &arg)
     return _default_device_index_type(d);
 }
 
-} // namespace py_internal
-} // namespace tensor
-} // namespace dpctl
+} // namespace dpctl::tensor::py_internal

dpctl_ext/tensor/libtensor/source/device_support_queries.hpp

@@ -36,14 +36,8 @@
 
 #include "dpnp4pybind11.hpp"
 #include <pybind11/pybind11.h>
-#include <pybind11/stl.h>
-#include <sycl/sycl.hpp>
 
-namespace dpctl
-{
-namespace tensor
-{
-namespace py_internal
+namespace dpctl::tensor::py_internal
 {
 
 extern std::string default_device_fp_type(const py::object &);
@@ -53,6 +47,4 @@ extern std::string default_device_bool_type(const py::object &);
 extern std::string default_device_complex_type(const py::object &);
 extern std::string default_device_index_type(const py::object &);
 
-} // namespace py_internal
-} // namespace tensor
-} // namespace dpctl
+} // namespace dpctl::tensor::py_internal

dpctl_ext/tensor/libtensor/source/simplify_iteration_space.cpp

@@ -34,15 +34,13 @@
 
 #include "simplify_iteration_space.hpp"
 #include "utils/strided_iters.hpp"
+#include <algorithm>
 #include <cstddef>
+#include <iterator>
 #include <pybind11/pybind11.h>
 #include <vector>
 
-namespace dpctl
-{
-namespace tensor
-{
-namespace py_internal
+namespace dpctl::tensor::py_internal
 {
 
 namespace py = pybind11;
@@ -539,6 +537,4 @@ std::vector<py::ssize_t> _unravel_index_f(py::ssize_t flat_index,
     return mi;
 }
 
-} // namespace py_internal
-} // namespace tensor
-} // namespace dpctl
+} // namespace dpctl::tensor::py_internal

dpctl_ext/tensor/libtensor/source/simplify_iteration_space.hpp

@@ -36,11 +36,7 @@
 #include <pybind11/pybind11.h>
 #include <vector>
 
-namespace dpctl
-{
-namespace tensor
-{
-namespace py_internal
+namespace dpctl::tensor::py_internal
 {
 
 namespace py = pybind11;
@@ -125,6 +121,5 @@ std::vector<py::ssize_t> _unravel_index_c(py::ssize_t,
                                           std::vector<py::ssize_t> const &);
 std::vector<py::ssize_t> _unravel_index_f(py::ssize_t,
                                           std::vector<py::ssize_t> const &);
-} // namespace py_internal
-} // namespace tensor
-} // namespace dpctl
+
+} // namespace dpctl::tensor::py_internal