🚧 Silent Push Sync flow test

Author: joaodordio

tests/business-critical-integration/scripts/run-tests.sh

@@ -48,8 +48,8 @@ emergency_cleanup() {
         xcrun simctl shutdown "$SIMULATOR_UUID_TO_CLEAN" 2>/dev/null || true
     fi
 
-    # Clean up any background processes
-    jobs -p | xargs -r kill 2>/dev/null || true
+    # Clean up push monitor specifically (don't kill all background jobs)
+    cleanup_push_monitoring
 
     echo_warning "Emergency cleanup completed. Exiting with code $exit_code"
     exit $exit_code
@@ -349,14 +349,14 @@ prepare_test_environment() {
     if [[ -n "$CI" ]] || [[ -n "$GITHUB_ACTIONS" ]] || [[ -n "$JENKINS_URL" ]] || [[ -n "$BUILDKITE" ]]; then
         export CI="1"
         echo_info "🤖 CI Environment detected - enabling mock push notifications"
-        # Update config.json with CI mode only when CI is detected
-        update_config_for_ci
     else
         export CI="0"
         echo_info "📱 Local Environment - using real APNS push notifications"
-        # Don't override existing config for local runs
     fi
 
+    # Always update config.json to match detected environment
+    update_config_for_ci
+    
     if [[ "$VERBOSE" == true ]]; then
         export ENABLE_DEBUG_LOGGING="1"
     fi
@@ -469,17 +469,7 @@ clear_screenshots_directory() {
 # MARK: - Push Notification Support
 
 setup_push_monitoring() {
-    # Check both CI env var and config.json ciMode setting
-    local CI_MODE="$CI"
-    if [[ -f "$LOCAL_CONFIG_FILE" ]] && command -v jq &> /dev/null; then
-        local CONFIG_CI_MODE=$(jq -r '.testing.ciMode // false' "$LOCAL_CONFIG_FILE")
-        if [[ "$CONFIG_CI_MODE" == "true" ]]; then
-            CI_MODE="1"
-            echo_info "🔍 CI mode detected from config.json (ciMode: true)"
-        fi
-    fi
-    
-    if [[ "$CI_MODE" == "1" ]]; then
+    if [[ "$CI" == "1" ]]; then
         echo_info "🤖 Setting up push notification monitoring for CI environment"
 
         # Create push queue directory
@@ -499,14 +489,29 @@ setup_push_monitoring() {
         echo "$MONITOR_PID" > "/tmp/push_monitor.pid"
 
         # Give it a moment to start
-        sleep 0.5
+        sleep 1
 
         # Verify it's running
         if ps -p "$MONITOR_PID" > /dev/null 2>&1; then
             echo_info "⚡ Push monitor started with PID: $MONITOR_PID"
+            
+            # Verify it's actually watching the directory
+            sleep 0.5
+            if [[ -f "$PUSH_MONITOR_LOG" ]]; then
+                if grep -q "Push monitor started" "$PUSH_MONITOR_LOG" 2>/dev/null; then
+                    echo_info "✓ Push monitor is actively watching for commands"
+                else
+                    echo_warning "⚠️ Push monitor log exists but may not be working correctly"
+                    cat "$PUSH_MONITOR_LOG"
+                fi
+            fi
         else
             echo_error "❌ Push monitor failed to start!"
-            cat "$PUSH_MONITOR_LOG"
+            if [[ -f "$PUSH_MONITOR_LOG" ]]; then
+                echo_error "Push monitor log:"
+                cat "$PUSH_MONITOR_LOG"
+            fi
+            echo_error "Push monitoring will not work!"
         fi
     else
         echo_info "📱 Local environment - push monitoring not needed"
@@ -517,35 +522,46 @@ start_push_monitor() {
     local PUSH_QUEUE_DIR="$1"
 
     # Use plain echo since this runs in background process
-    echo "[$(date '+%Y-%m-%d %H:%M:%S')] 🔄 Push monitor started - watching: $PUSH_QUEUE_DIR"
+    echo "[$(date '+%Y-%m-%d %H:%M:%S')] 🔄 Push monitor started - watching: $PUSH_QUEUE_DIR" >&2
+    echo "[$(date '+%Y-%m-%d %H:%M:%S')] 🔄 Monitor PID: $$" >&2
+    
+    # Verify directory exists and is writable
+    if [[ ! -d "$PUSH_QUEUE_DIR" ]]; then
+        echo "[$(date '+%Y-%m-%d %H:%M:%S')] ❌ ERROR: Push queue directory does not exist: $PUSH_QUEUE_DIR" >&2
+        exit 1
+    fi
+    
+    echo "[$(date '+%Y-%m-%d %H:%M:%S')] ✓ Directory verified: $PUSH_QUEUE_DIR" >&2
 
     while true; do
         # Look for new command files
         for COMMAND_FILE in "$PUSH_QUEUE_DIR"/command_*.txt; do
+            # Skip if no files match the pattern
+            [[ -e "$COMMAND_FILE" ]] || continue
             [[ -f "$COMMAND_FILE" ]] || continue
 
-            echo "[$(date '+%Y-%m-%d %H:%M:%S')] 📋 Found command file: $COMMAND_FILE"
+            echo "[$(date '+%Y-%m-%d %H:%M:%S')] 📋 Found command file: $COMMAND_FILE" >&2
 
             # Read and execute the command
             local COMMAND=$(cat "$COMMAND_FILE" 2>/dev/null)
             if [[ -n "$COMMAND" ]]; then
-                echo "[$(date '+%Y-%m-%d %H:%M:%S')] 🚀 Executing push command: $COMMAND"
+                echo "[$(date '+%Y-%m-%d %H:%M:%S')] 🚀 Executing push command: $COMMAND" >&2
 
                 # Execute the xcrun simctl command
                 eval "$COMMAND" 2>&1
                 local EXIT_CODE=$?
 
                 if [[ $EXIT_CODE -eq 0 ]]; then
-                    echo "[$(date '+%Y-%m-%d %H:%M:%S')] ✅ Push notification sent successfully"
+                    echo "[$(date '+%Y-%m-%d %H:%M:%S')] ✅ Push notification sent successfully" >&2
                 else
-                    echo "[$(date '+%Y-%m-%d %H:%M:%S')] ❌ Push notification failed with exit code: $EXIT_CODE"
+                    echo "[$(date '+%Y-%m-%d %H:%M:%S')] ❌ Push notification failed with exit code: $EXIT_CODE" >&2
                 fi
 
                 # Remove the command file after processing
                 rm -f "$COMMAND_FILE"
-                echo "[$(date '+%Y-%m-%d %H:%M:%S')] 🗑️ Cleaned up command file: $COMMAND_FILE"
+                echo "[$(date '+%Y-%m-%d %H:%M:%S')] 🗑️ Cleaned up command file: $COMMAND_FILE" >&2
             else
-                echo "[$(date '+%Y-%m-%d %H:%M:%S')] ⚠️ Empty command file: $COMMAND_FILE"
+                echo "[$(date '+%Y-%m-%d %H:%M:%S')] ⚠️ Empty command file: $COMMAND_FILE" >&2
                 rm -f "$COMMAND_FILE"
             fi
         done