Skip to content

Commit 1b6d009

Browse files
feat: add default appProtocol on oc receiver (open-telemetry#2486)
* feat: add default appProtocol on oc receiver Signed-off-by: Husni Alhamdani <[email protected]> * feat: add default appProtocol on oc receiver Signed-off-by: Husni Alhamdani <[email protected]> * feat: add default appProtocol on oc receiver Signed-off-by: Husni Alhamdani <[email protected]> --------- Signed-off-by: Husni Alhamdani <[email protected]>
1 parent f508392 commit 1b6d009

File tree

2 files changed

+23
-5
lines changed

2 files changed

+23
-5
lines changed

.chloggen/main.yaml

+16
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
2+
change_type: bug_fix
3+
4+
# The name of the component, or a single word describing the area of concern, (e.g. operator, target allocator, github action)
5+
component: operator
6+
7+
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
8+
note: add missing appProtocol in opencensus receiver
9+
10+
# One or more tracking issues related to the change
11+
issues: [2487]
12+
13+
# (Optional) One or more lines of additional information to render under the primary note.
14+
# These lines will be padded with 2 spaces and then inserted directly into the document.
15+
# Use pipe (|) for multiline entries.
16+
subtext:

internal/manifests/collector/parser/receiver/receiver_oc.go

+7-5
Original file line numberDiff line numberDiff line change
@@ -24,12 +24,14 @@ const parserNameOpenCensus = "__opencensus"
2424

2525
// NewOpenCensusReceiverParser builds a new parser for OpenCensus receivers.
2626
func NewOpenCensusReceiverParser(logger logr.Logger, name string, config map[interface{}]interface{}) parser.ComponentPortParser {
27+
httpAppProtocol := "http"
2728
return &GenericReceiver{
28-
logger: logger,
29-
name: name,
30-
config: config,
31-
defaultPort: 55678,
32-
parserName: parserNameOpenCensus,
29+
logger: logger,
30+
name: name,
31+
config: config,
32+
defaultPort: 55678,
33+
parserName: parserNameOpenCensus,
34+
defaultAppProtocol: &httpAppProtocol,
3335
}
3436
}
3537

0 commit comments

Comments
 (0)