Skip to content

Commit e07e346

Browse files
authored
fix: Make install run within Makefile string interpolation issue (open-telemetry#2520)
* fix: Make install run within Makefile to work this fix fixes errors such as "github.com/open-telemetry/opentelemetry-operator/internal/version.version=0.91.0-20-gd013d45": invalid char '=' Signed-off-by: Todd Yan <[email protected]> * fix makefile for run --------- Signed-off-by: Todd Yan <[email protected]>
1 parent 953178b commit e07e346

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

Makefile

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# Current Operator version
22
VERSION ?= $(shell git describe --tags | sed 's/^v//')
33
VERSION_DATE ?= $(shell date -u +'%Y-%m-%dT%H:%M:%SZ')
4-
VERSION_PKG ?= "github.com/open-telemetry/opentelemetry-operator/internal/version"
4+
VERSION_PKG ?= github.com/open-telemetry/opentelemetry-operator/internal/version
55
OTELCOL_VERSION ?= "$(shell grep -v '\#' versions.txt | grep opentelemetry-collector | awk -F= '{print $$2}')"
66
OPERATOR_VERSION ?= "$(shell grep -v '\#' versions.txt | grep operator= | awk -F= '{print $$2}')"
77
TARGETALLOCATOR_VERSION ?= $(shell grep -v '\#' versions.txt | grep targetallocator | awk -F= '{print $$2}')
@@ -119,7 +119,7 @@ operator-opamp-bridge:
119119
# Run against the configured Kubernetes cluster in ~/.kube/config
120120
.PHONY: run
121121
run: generate fmt vet manifests
122-
ENABLE_WEBHOOKS=$(ENABLE_WEBHOOKS) go run -ldflags ${OPERATOR_LDFLAGS} ./main.go --zap-devel
122+
ENABLE_WEBHOOKS=$(ENABLE_WEBHOOKS) go run -ldflags "${OPERATOR_LDFLAGS}" ./main.go --zap-devel
123123

124124
# Install CRDs into a cluster
125125
.PHONY: install

0 commit comments

Comments
 (0)