Feature/app/allow costum symptoms #260

HaggitheSecond · 2025-10-15T07:26:53Z

Allows adding custom symptoms and setup what default symptoms show up when logging a day.

View when logging a new day or editing an existing log:

View in settings:

J-shw · 2025-10-15T08:40:05Z

This is very nice!

I don't have time right now to review it all. But I will spin it up before the end of the week.

J-shw · 2025-10-16T20:20:41Z

Ok I just managed to spin this up now. I had some dependancy issues (not related to this pr) but that is something else that will need to be looked at..

Anyway, this is awesome!

One question, the make default symptom button. I thought that would mean everytime I create a log it will auto select that symptom but it does not. Is that a bug?

Also that mark button does not show on the period settings screen when adding a new symptom there.

J-shw

These changes are not logic based, just some really quick things to make the imports more resilient for if files get moved around.

app/lib/screens/settings/period_settings_screen.dart

app/lib/widgets/sheets/period_details_bottom_sheet.dart

app/lib/widgets/sheets/symptom_entry_sheet.dart

J-shw · 2025-10-16T20:52:38Z

Just another thing I thought about, we should store the symptoms all lower case in the db. Then display them with the inital character upper case. I feel trying to add some consistancy to the storage/display of the data might be nice overall.

HaggitheSecond · 2025-10-19T07:55:18Z

Ok I just managed to spin this up now. I had some dependancy issues (not related to this pr) but that is something else that will need to be looked at..

Anyway, this is awesome!

One question, the make default symptom button. I thought that would mean everytime I create a log it will auto select that symptom but it does not. Is that a bug?

Also that mark button does not show on the period settings screen when adding a new symptom there.

That is a good point. Right now it's supposed to be treated as "default symptom" -> always shows up but is not preselected. That might be a good clarification to make somewhere.

Regarding the second point, this mark button does not make sense to have in the settings screen, as you can only add default symptoms here anyways, so it would not do anything.

J-shw · 2025-10-19T16:54:29Z

Right now it's supposed to be treated as "default symptom" -> always shows up but is not preselected.

What does this mean? Do you mean it adds it to the list of default symptoms in app. So its more of a behind the scenese thing.

I don't understand what changes if I select default or not.

Cheers

J-shw · 2025-10-20T20:03:03Z

Hi @HaggitheSecond

This is coming along really nicely! While looking over your code I noticed that you found issues with the current implementation of how symptoms are stored. Which causes issues for when you want to count the total uses ect..

Anyway, I have made a new issue (And am about to fix it) to migrate the symptoms to their own DB table. While doing this I also thought that we could store the symptom text values in a DB too.

So a the symptom table would be:

id	symptom
1	cramps
2	headache
3	mood swings

And we just assign a foreign key in my new symptom_log table that is associated with the symptom IDs:

id	symptom_id	period_log_id
1	1	22
2	1	23
3	2	23

The latest changes will probably cause merge conflicts on this branch (sorry!) but it will make the logic more sound in the long run.

HaggitheSecond · 2025-10-29T08:29:00Z

@J-shw i've reworked this quite a bit and introduced a Symptom type that allows for both proper localization of built in symtpoms and also allows for future expansion.
This will likely need a bit more hardening, it feels a bit prone to issues right now, but that'll be something to do later, I think.

Since I consider this mostly done (if not bug free), I'll open this and remove the draft status.

J-shw · 2025-10-29T09:09:00Z

This is awesome! I will load it up later when I get back from work and have a look around it

Slight issue still: - Insights are wrong, I logged 'test' twice and it only shows it as 1 Day. - The translated value is wrong. The value displayed on the graph seems to be the store value and not the translated one (for default values)

J-shw · 2025-10-31T18:00:05Z

Hi @HaggitheSecond this is looking good!

Turns out I can just commit to this branch lol..

So its all working with the new setting service, but as per this commit there are still some issues with the insights data. I have not got time tonight to look at it, but I can tomorrow

Now when users log a symptom the value is saved as en english string, this should help users who export data or if they want to import and we have changed the symptom enum ect..

This is for the '+ Add' button.

J-shw · 2025-11-01T14:56:28Z

Hi @HaggitheSecond I have made some more changes and I think this system is pretty much there!

I have changed a few things:

System now supports new setting service model
Default symptoms are saved as english strings in db for better export/import funcitonality
All values saved in the DB are lower case
Custom symptoms are saved as lowercase in settings (Also trims any whitespace)
Custom symptoms displayed are capitalised when displayed
Removed other symptom type
Add and reset buttons are now action buttons and use icons for + and reset
These new action buttons are used on log bottom sheets and settings screen
Renamed setting screen from period logging to logs (Due to symptoms being logged even when not on a period)
Changed log setting icon
Reordered settings

I think thats everything?

Anyway, if there is anything I have missed or you don't agree with just let me know.

And once we are both happy with this, we can merge it all!

J-shw linked an issue Oct 16, 2025 that may be closed by this pull request

[FEATURE] More symptoms #212

Open

J-shw requested changes Oct 16, 2025

View reviewed changes

HaggitheSecond force-pushed the feature/app/allow_costum_symptoms branch from 5ecb8ae to e6729f5 Compare October 19, 2025 07:53

J-shw mentioned this pull request Oct 20, 2025

[FEATURE] Separate Symptom DB table #293

Closed

HaggitheSecond force-pushed the feature/app/allow_costum_symptoms branch 2 times, most recently from 49d14ae to 1a531b8 Compare October 29, 2025 08:25

HaggitheSecond marked this pull request as ready for review October 29, 2025 08:29

HaggitheSecond added 15 commits October 29, 2025 10:25

Add functionality to add custom symptoms when logging period

95c6040

Finish up custom dymptom dialog

584e537

Add sharedpreferences setting for default symptoms

9043b4c

Add simple add/remove default symptoms settings

581854b

Remove symptoms enum and update period_details_bottom_sheet

b650719

Add warning on delete

86b79e1

Fix error saving log

6244a15

Allow adding new custom symptoms when editing existing log

cc562ef

Add more description on no symptom usage

031a096

Fix merge issues

7f888e9

Add localization

1461d16

Use package for uri in imports

3e53ae4

Ensure symptoms get saved in lowercase

9557200

Add new translations and some .idea files

40687bc

Exchange "make default symptom" with "is temporary symptom"

1c6f97c

J-shw added 8 commits October 31, 2025 17:36

Reconfigured the new symptom setting methods

1748aa0

Uses new setting service system

315b928

Updated settings service support

51e3052

Removed const from PeriodLogSettingsScreen

a110ef2

Removed unused import

ef50d99

Updated settings service usage

395ccf0

Small fix to symptomCounts data type

b3fde5b

J-shw added 19 commits October 31, 2025 18:16

Corrected hashCode method

d825a86

Removed unused import

ccab226

Fixed _showNewCustomSymptomDialog method logic

9ed820b

Renamed symptom types

cca5e93

Uses new symptom types + revamped saving system

0ce7441

Now when users log a symptom the value is saved as en english string, this should help users who export data or if they want to import and we have changed the symptom enum ect..

Fixed symptom logic to use new name/enum convention

651adf0

Lower case s for swings

ba497f2

Symptom is now trimmed and set to lowercase when accepting

3abd43f

Updated translations + changed Period Logging to Logging

110118d

Renamed to log_settings_screen

881ce10

Updated LogSettingScreen and reconfigured setting icons

9b8adb7

Reordered settings

86175da

Added 'Add' translation

1af9fc0

Removed other

75ff887

Removed other symptoms uses + removed refresh and add symptom

b65bbf5

Replaced 'rawChip' with 'actionChip' and use built in icons

b5daa27

Removed check for old symptom type

a8321a3

Removed check for another old symptom type

7c987cb

Removed old other symptom system and use new actionChip system

64ea4f2

This is for the '+ Add' button.

Removed unused imports

1d5811d

Feature/app/allow costum symptoms #260

Are you sure you want to change the base?

Feature/app/allow costum symptoms #260

Uh oh!

Conversation

HaggitheSecond commented Oct 15, 2025

Uh oh!

J-shw commented Oct 15, 2025

Uh oh!

J-shw commented Oct 16, 2025

Uh oh!

J-shw left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

J-shw commented Oct 16, 2025

Uh oh!

HaggitheSecond commented Oct 19, 2025

Uh oh!

J-shw commented Oct 19, 2025

Uh oh!

J-shw commented Oct 20, 2025

Uh oh!

HaggitheSecond commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

J-shw commented Oct 29, 2025

Uh oh!

J-shw commented Oct 31, 2025

Uh oh!

J-shw commented Nov 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

HaggitheSecond commented Oct 29, 2025 •

edited

Loading