Skip to content

Commit 91de4a9

Browse files
committed
fix: use patched nan version - see nodejs/nan#982
1 parent 293bda8 commit 91de4a9

File tree

2 files changed

+16
-22
lines changed

2 files changed

+16
-22
lines changed

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@
7777
"dependencies": {
7878
"@mapbox/node-pre-gyp": "1.0.11",
7979
"env-paths": "2.2.0",
80-
"nan": "2.22.0",
80+
"nan": "github:JCMais/nan#fix/electron-v28-build-failure",
8181
"node-gyp": "10.2.0",
8282
"npmlog": "7.0.1",
8383
"rimraf": "5.0.5",
@@ -100,7 +100,7 @@
100100
"cheerio": "1.0.0-rc.3",
101101
"clang-format": "1.8.0",
102102
"cookie-parser": "1.4.6",
103-
"electron": "32.2.6",
103+
"electron": "28.3.3",
104104
"eslint": "8.55.0",
105105
"eslint-config-prettier": "9.1.0",
106106
"eslint-formatter-friendly": "7.0.0",

yarn.lock

Lines changed: 14 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1314,20 +1314,20 @@
13141314
dependencies:
13151315
undici-types "~5.26.4"
13161316

1317+
"@types/node@^18.11.18":
1318+
version "18.19.67"
1319+
resolved "https://registry.yarnpkg.com/@types/node/-/node-18.19.67.tgz#77c4b01641a1e3e1509aff7e10d39e4afd5ae06d"
1320+
integrity sha512-wI8uHusga+0ZugNp0Ol/3BqQfEcCCNfojtO6Oou9iVNGPTL6QNSdnUdqq85fRgIorLhLMuPIKpsN98QE9Nh+KQ==
1321+
dependencies:
1322+
undici-types "~5.26.4"
1323+
13171324
"@types/node@^18.11.9":
13181325
version "18.19.2"
13191326
resolved "https://registry.yarnpkg.com/@types/node/-/node-18.19.2.tgz#865107157bda220eef9fa8c2173152d6559a41ae"
13201327
integrity sha512-6wzfBdbWpe8QykUkXBjtmO3zITA0A3FIjoy+in0Y2K4KrCiRhNYJIdwAPDffZ3G6GnaKaSLSEa9ZuORLfEoiwg==
13211328
dependencies:
13221329
undici-types "~5.26.4"
13231330

1324-
"@types/node@^20.9.0":
1325-
version "20.17.9"
1326-
resolved "https://registry.yarnpkg.com/@types/node/-/node-20.17.9.tgz#5f141d4b7ee125cdee5faefe28de095398865bab"
1327-
integrity sha512-0JOXkRyLanfGPE2QRCwgxhzlBAvaRdCNMcvbd7jFfpmD4eEXll7LRwy5ymJmyeZqk7Nh7eD2LeUyQ68BbndmXw==
1328-
dependencies:
1329-
undici-types "~6.19.2"
1330-
13311331
"@types/normalize-package-data@^2.4.0":
13321332
version "2.4.0"
13331333
resolved "https://registry.npmjs.org/@types/normalize-package-data/-/normalize-package-data-2.4.0.tgz#e486d0d97396d79beedd0a6e33f4534ff6b4973e"
@@ -3018,13 +3018,13 @@ [email protected]:
30183018
resolved "https://registry.npmjs.org/ee-first/-/ee-first-1.1.1.tgz#590c61156b0ae2f4f0255732a158b266bc56b21d"
30193019
integrity sha1-WQxhFWsK4vTwJVcyoViyZrxWsh0=
30203020

3021-
electron@32.2.6:
3022-
version "32.2.6"
3023-
resolved "https://registry.yarnpkg.com/electron/-/electron-32.2.6.tgz#564ff0cc163fb318070c989bc1066c5943ae882e"
3024-
integrity sha512-aGG1MLvWCf+ECUFBCmaCF52F8312OPAJfph2D0FSsFmlbfnJuNevZCbty2lFzsiIMtU7/QRo6d0ksbgR4s7y3w==
3021+
electron@28.3.3:
3022+
version "28.3.3"
3023+
resolved "https://registry.yarnpkg.com/electron/-/electron-28.3.3.tgz#2df898f653c4f77b66b4cf3eeba79d8bea6d03c0"
3024+
integrity sha512-ObKMLSPNhomtCOBAxFS8P2DW/4umkh72ouZUlUKzXGtYuPzgr1SYhskhFWgzAsPtUzhL2CzyV2sfbHcEW4CXqw==
30253025
dependencies:
30263026
"@electron/get" "^2.0.0"
3027-
"@types/node" "^20.9.0"
3027+
"@types/node" "^18.11.18"
30283028
extract-zip "^2.0.1"
30293029

30303030
elegant-spinner@^1.0.1:
@@ -5854,10 +5854,9 @@ [email protected]:
58545854
resolved "https://registry.yarnpkg.com/mute-stream/-/mute-stream-1.0.0.tgz#e31bd9fe62f0aed23520aa4324ea6671531e013e"
58555855
integrity sha512-avsJQhyd+680gKXyG/sQc0nXaC6rBkPOfyHYcFb9+hdkqQkR9bdnkJ0AMZhke0oesPqIO+mFFJ+IdBc7mst4IA==
58565856

5857-
nan@2.22.0:
5857+
"nan@github:JCMais/nan#fix/electron-v28-build-failure":
58585858
version "2.22.0"
5859-
resolved "https://registry.yarnpkg.com/nan/-/nan-2.22.0.tgz#31bc433fc33213c97bad36404bb68063de604de3"
5860-
integrity sha512-nbajikzWTMwsW+eSsNm3QwlOs7het9gGJU5dDZzRTQGk03vyBOauxgI4VakDzE0PtsGTmXPsXTbbjVhRwR5mpw==
5859+
resolved "https://codeload.github.com/JCMais/nan/tar.gz/bc38a3894dd9ef4576bc0dd77a65c9901eaa981b"
58615860

58625861
nanoid@^3.3.7:
58635862
version "3.3.8"
@@ -8172,11 +8171,6 @@ undici-types@~5.26.4:
81728171
resolved "https://registry.yarnpkg.com/undici-types/-/undici-types-5.26.5.tgz#bcd539893d00b56e964fd2657a4866b221a65617"
81738172
integrity sha512-JlCMO+ehdEIKqlFxk6IfVoAUVmgz7cU7zD/h9XZ0qzeosSHmUJVOzSQvvYSYWXkFXC+IfLKSIffhv0sVZup6pA==
81748173

8175-
undici-types@~6.19.2:
8176-
version "6.19.8"
8177-
resolved "https://registry.yarnpkg.com/undici-types/-/undici-types-6.19.8.tgz#35111c9d1437ab83a7cdc0abae2f26d88eda0a02"
8178-
integrity sha512-ve2KP6f/JnbPBFyobGHuerC9g1FYGn/F8n1LWTwNxCEzd6IfqTwUQcNXgEtmmQ6DlRrC1hrSrBnCZPokRrDHjw==
8179-
81808174
unicorn-magic@^0.1.0:
81818175
version "0.1.0"
81828176
resolved "https://registry.yarnpkg.com/unicorn-magic/-/unicorn-magic-0.1.0.tgz#1bb9a51c823aaf9d73a8bfcd3d1a23dde94b0ce4"

0 commit comments

Comments
 (0)