EF materializer nonstandard id bug #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Trying to make pull requests for my own changes...still getting used to really using Git and GitHub. |
Collaborator
There was a problem hiding this comment.
I really like FluentAssertions for this sort of thing. You can do:
Action action = () =>
{
IEnumerable<string> keyNames = materializer.GetKeyNames(typeof(NotAnEntity));
};
action.ShouldThrow<ArgumentException>();
which I think is clearer than adding an attribute on the method. You can also add additional checks against the exception object itself, which you can't do with the MSTest approach.
Collaborator
|
Oh yeah, I think I ran into this the other day. 👍 |
SphtKr
added a commit
that referenced
this pull request
Feb 9, 2015
EF materializer nonstandard id bug
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetKeyNameswas completely broken, actually: it was always returning onlyId, and swallowing an exception on every run. Now it properly checks for several conditions, and has tests to back it up.Also fixed
TestEntitiesto be able to delete the DB and recreate the model if it changes (which it did in this commit).